Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

NFS: Remove duplicate svc_xprt_put from nfs41_callback_up

The xprt created by svc_create_xprt have be added to serv->sv_permsocks.
So putting the xprt directly is useless.
Otherwise, there is a more svc_xprt_put after the xprt be freed.

v2, same as v1.

Signed-off-by: Kinglong Mee <kinglongmee@gmail.com>
Signed-off-by: Trond Myklebust <trond.myklebust@primarydata.com>

authored by

Kinglong Mee and committed by
Trond Myklebust
0847ef88 5ef8d792

-4
-4
fs/nfs/callback.c
··· 162 162 spin_lock_init(&serv->sv_cb_lock); 163 163 init_waitqueue_head(&serv->sv_cb_waitq); 164 164 rqstp = svc_prepare_thread(serv, &serv->sv_pools[0], NUMA_NO_NODE); 165 - if (IS_ERR(rqstp)) { 166 - svc_xprt_put(serv->sv_bc_xprt); 167 - serv->sv_bc_xprt = NULL; 168 - } 169 165 dprintk("--> %s return %d\n", __func__, PTR_ERR_OR_ZERO(rqstp)); 170 166 return rqstp; 171 167 }