Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

USB2NET : SR9800 : change SR9800_BULKIN_SIZE from global to static

Smatch reports this issue
sr9800.h:166:53: warning: symbol 'SR9800_BULKIN_SIZE' was not declared. Should it be static?

Global variables should not be defined in header files.
This only works because sr9800.h in only included by sr9800.c
Change the storage-class specifier to static.
And since it does not change add type qualifier const.

Signed-off-by: Tom Rix <trix@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

authored by

Tom Rix and committed by
David S. Miller
0844d36f 6f37c9f9

+1 -1
+1 -1
drivers/net/usb/sr9800.h
··· 163 163 #define SR9800_MAX_BULKIN_24K 6 164 164 #define SR9800_MAX_BULKIN_32K 7 165 165 166 - struct {unsigned short size, byte_cnt, threshold; } SR9800_BULKIN_SIZE[] = { 166 + static const struct {unsigned short size, byte_cnt, threshold; } SR9800_BULKIN_SIZE[] = { 167 167 /* 2k */ 168 168 {2048, 0x8000, 0x8001}, 169 169 /* 4k */