Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

drivers/char/isicom.c: correct use of ! and &

In commit e6bafba5b4765a5a252f1b8d31cbf6d2459da337 ("wmi: (!x & y)
strikes again"), a bug was fixed that involved converting !x & y to !(x
& y). The code below shows the same pattern, and thus should perhaps be
fixed in the same way.

This is not tested and clearly changes the semantics, so it is only
something to consider.

The semantic patch that makes this change is as follows:
(http://www.emn.fr/x-info/coccinelle/)

// <smpl>
@@ expression E1,E2; @@
(
!E1 & !E2
|
- !E1 & E2
+ !(E1 & E2)
)
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Cc: Jiri Slaby <jirislaby@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

authored by

Julia Lawall and committed by
Linus Torvalds
07fb6f26 fb59e9f1

+1 -1
+1 -1
drivers/char/isicom.c
··· 1527 1527 msleep(10); 1528 1528 1529 1529 portcount = inw(base + 0x2); 1530 - if (!inw(base + 0xe) & 0x1 || (portcount != 0 && portcount != 4 && 1530 + if (!(inw(base + 0xe) & 0x1) || (portcount != 0 && portcount != 4 && 1531 1531 portcount != 8 && portcount != 16)) { 1532 1532 dev_err(&pdev->dev, "ISILoad:PCI Card%d reset failure.\n", 1533 1533 card + 1);