Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

skb: Add tracepoints to freeing skb

This patch adds tracepoint to consume_skb and add trace_kfree_skb
before __kfree_skb in skb_free_datagram_locked and net_tx_action.
Combinating with tracepoint on dev_hard_start_xmit, we can check
how long it takes to free transmitted packets. And using it, we can
calculate how many packets driver had at that time. It is useful when
a drop of transmitted packet is a problem.

sshd-6828 [000] 112689.258154: consume_skb: skbaddr=f2d99bb8

Signed-off-by: Koki Sanagi <sanagi.koki@jp.fujitsu.com>
Acked-by: David S. Miller <davem@davemloft.net>
Acked-by: Neil Horman <nhorman@tuxdriver.com>
Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Cc: Kaneshige Kenji <kaneshige.kenji@jp.fujitsu.com>
Cc: Izumo Taku <izumi.taku@jp.fujitsu.com>
Cc: Kosaki Motohiro <kosaki.motohiro@jp.fujitsu.com>
Cc: Lai Jiangshan <laijs@cn.fujitsu.com>
Cc: Scott Mcmillan <scott.a.mcmillan@intel.com>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: Eric Dumazet <eric.dumazet@gmail.com>
LKML-Reference: <4C724364.50903@jp.fujitsu.com>
Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>

authored by

Koki Sanagi and committed by
Frederic Weisbecker
07dc22e7 cf66ba58

+21
+17
include/trace/events/skb.h
··· 35 35 __entry->skbaddr, __entry->protocol, __entry->location) 36 36 ); 37 37 38 + TRACE_EVENT(consume_skb, 39 + 40 + TP_PROTO(struct sk_buff *skb), 41 + 42 + TP_ARGS(skb), 43 + 44 + TP_STRUCT__entry( 45 + __field( void *, skbaddr ) 46 + ), 47 + 48 + TP_fast_assign( 49 + __entry->skbaddr = skb; 50 + ), 51 + 52 + TP_printk("skbaddr=%p", __entry->skbaddr) 53 + ); 54 + 38 55 TRACE_EVENT(skb_copy_datagram_iovec, 39 56 40 57 TP_PROTO(const struct sk_buff *skb, int len),
+1
net/core/datagram.c
··· 243 243 unlock_sock_fast(sk, slow); 244 244 245 245 /* skb is now orphaned, can be freed outside of locked section */ 246 + trace_kfree_skb(skb, skb_free_datagram_locked); 246 247 __kfree_skb(skb); 247 248 } 248 249 EXPORT_SYMBOL(skb_free_datagram_locked);
+2
net/core/dev.c
··· 129 129 #include <linux/random.h> 130 130 #include <trace/events/napi.h> 131 131 #include <trace/events/net.h> 132 + #include <trace/events/skb.h> 132 133 #include <linux/pci.h> 133 134 134 135 #include "net-sysfs.h" ··· 2577 2576 clist = clist->next; 2578 2577 2579 2578 WARN_ON(atomic_read(&skb->users)); 2579 + trace_kfree_skb(skb, net_tx_action); 2580 2580 __kfree_skb(skb); 2581 2581 } 2582 2582 }
+1
net/core/skbuff.c
··· 466 466 smp_rmb(); 467 467 else if (likely(!atomic_dec_and_test(&skb->users))) 468 468 return; 469 + trace_consume_skb(skb); 469 470 __kfree_skb(skb); 470 471 } 471 472 EXPORT_SYMBOL(consume_skb);