Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

netlink: specs: ethtool: replace underscores with dashes in names

We're trying to add a strict regexp for the name format in the spec.
Underscores will not be allowed, dashes should be used instead.
This makes no difference to C (codegen replaces special chars in names)
but gives more uniform naming in Python.

Fixes: 13e59344fb9d ("net: ethtool: add support for symmetric-xor RSS hash")
Fixes: 46fb3ba95b93 ("ethtool: Add an interface for flashing transceiver modules' firmware")
Reviewed-by: Kory Maincent <kory.maincent@bootlin.com>
Reviewed-by: Donald Hunter <donald.hunter@gmail.com>
Link: https://patch.msgid.link/20250624211002.3475021-4-kuba@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

+4 -4
+3 -3
Documentation/netlink/specs/ethtool.yaml
··· 48 48 name: started 49 49 doc: The firmware flashing process has started. 50 50 - 51 - name: in_progress 51 + name: in-progress 52 52 doc: The firmware flashing process is in progress. 53 53 - 54 54 name: completed ··· 1422 1422 name: hkey 1423 1423 type: binary 1424 1424 - 1425 - name: input_xfrm 1425 + name: input-xfrm 1426 1426 type: u32 1427 1427 - 1428 1428 name: start-context ··· 2238 2238 - hfunc 2239 2239 - indir 2240 2240 - hkey 2241 - - input_xfrm 2241 + - input-xfrm 2242 2242 dump: 2243 2243 request: 2244 2244 attributes:
+1 -1
tools/testing/selftests/drivers/net/hw/rss_input_xfrm.py
··· 38 38 raise KsftSkipEx("socket.SO_INCOMING_CPU was added in Python 3.11") 39 39 40 40 input_xfrm = cfg.ethnl.rss_get( 41 - {'header': {'dev-name': cfg.ifname}}).get('input_xfrm') 41 + {'header': {'dev-name': cfg.ifname}}).get('input-xfrm') 42 42 43 43 # Check for symmetric xor/or-xor 44 44 if not input_xfrm or (input_xfrm != 1 and input_xfrm != 2):