Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

regmap: debugfs: document why we don't create the debugfs entries

This is a follow-up to commit a5ba91c380b8 ("regmap: debugfs: emit a
debug message when locking is disabled"). I figured that a user may
see this message, grep the code, come to this place and he still won't
know why we actually disabled debugfs.

Add a comment explaining the reason.

Signed-off-by: Bartosz Golaszewski <brgl@bgdev.pl>
Signed-off-by: Mark Brown <broonie@kernel.org>

authored by

Bartosz Golaszewski and committed by
Mark Brown
078711d7 a5ba91c3

+7
+7
drivers/base/regmap/regmap-debugfs.c
··· 529 529 struct regmap_range_node *range_node; 530 530 const char *devname = "dummy"; 531 531 532 + /* 533 + * Userspace can initiate reads from the hardware over debugfs. 534 + * Normally internal regmap structures and buffers are protected with 535 + * a mutex or a spinlock, but if the regmap owner decided to disable 536 + * all locking mechanisms, this is no longer the case. For safety: 537 + * don't create the debugfs entries if locking is disabled. 538 + */ 532 539 if (map->debugfs_disable) { 533 540 dev_dbg(map->dev, "regmap locking disabled - not creating debugfs entries\n"); 534 541 return;