Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

dlm: use INFO for recovery messages

The log messages relating to the progress of recovery
are minimal and very often useful. Change these to
the KERN_INFO level so they are always available.

Signed-off-by: David Teigland <teigland@redhat.com>

+46 -47
+1 -1
fs/dlm/ast.c
··· 309 309 mutex_unlock(&ls->ls_cb_mutex); 310 310 311 311 if (count) 312 - log_debug(ls, "dlm_callback_resume %d", count); 312 + log_rinfo(ls, "dlm_callback_resume %d", count); 313 313 } 314 314
+2 -2
fs/dlm/dir.c
··· 68 68 uint16_t namelen; 69 69 unsigned int count = 0, count_match = 0, count_bad = 0, count_add = 0; 70 70 71 - log_debug(ls, "dlm_recover_directory"); 71 + log_rinfo(ls, "dlm_recover_directory"); 72 72 73 73 if (dlm_no_directory(ls)) 74 74 goto out_status; ··· 189 189 error = 0; 190 190 dlm_set_recover_status(ls, DLM_RS_DIR); 191 191 192 - log_debug(ls, "dlm_recover_directory %u in %u new", 192 + log_rinfo(ls, "dlm_recover_directory %u in %u new", 193 193 count, count_add); 194 194 out_free: 195 195 kfree(last_name);
+2
fs/dlm/dlm_internal.h
··· 65 65 printk(KERN_ERR "dlm: "fmt"\n" , ##args) 66 66 #define log_error(ls, fmt, args...) \ 67 67 printk(KERN_ERR "dlm: %s: " fmt "\n", (ls)->ls_name , ##args) 68 + #define log_rinfo(ls, fmt, args...) \ 69 + printk(KERN_INFO "dlm: %s: " fmt "\n", (ls)->ls_name , ##args); 68 70 69 71 #define log_debug(ls, fmt, args...) \ 70 72 do { \
+3 -3
fs/dlm/lock.c
··· 5463 5463 up_write(&ls->ls_root_sem); 5464 5464 5465 5465 if (lkb_count) 5466 - log_debug(ls, "dlm_recover_purge %u locks for %u nodes", 5466 + log_rinfo(ls, "dlm_recover_purge %u locks for %u nodes", 5467 5467 lkb_count, nodes_count); 5468 5468 } 5469 5469 ··· 5537 5537 } 5538 5538 5539 5539 if (lkb_count) 5540 - log_debug(ls, "dlm_recover_grant %u locks on %u resources", 5540 + log_rinfo(ls, "dlm_recover_grant %u locks on %u resources", 5541 5541 lkb_count, rsb_count); 5542 5542 } 5543 5543 ··· 5696 5696 put_rsb(r); 5697 5697 out: 5698 5698 if (error && error != -EEXIST) 5699 - log_debug(ls, "dlm_recover_master_copy remote %d %x error %d", 5699 + log_rinfo(ls, "dlm_recover_master_copy remote %d %x error %d", 5700 5700 from_nodeid, remid, error); 5701 5701 rl->rl_result = cpu_to_le32(error); 5702 5702 return error;
+4 -4
fs/dlm/lockspace.c
··· 190 190 else 191 191 kobject_uevent(&ls->ls_kobj, KOBJ_OFFLINE); 192 192 193 - log_debug(ls, "%s the lockspace group...", in ? "joining" : "leaving"); 193 + log_rinfo(ls, "%s the lockspace group...", in ? "joining" : "leaving"); 194 194 195 195 /* dlm_controld will see the uevent, do the necessary group management 196 196 and then write to sysfs to wake us */ ··· 198 198 error = wait_event_interruptible(ls->ls_uevent_wait, 199 199 test_and_clear_bit(LSFL_UEVENT_WAIT, &ls->ls_flags)); 200 200 201 - log_debug(ls, "group event done %d %d", error, ls->ls_uevent_result); 201 + log_rinfo(ls, "group event done %d %d", error, ls->ls_uevent_result); 202 202 203 203 if (error) 204 204 goto out; ··· 640 640 641 641 dlm_create_debug_file(ls); 642 642 643 - log_debug(ls, "join complete"); 643 + log_rinfo(ls, "join complete"); 644 644 *lockspace = ls; 645 645 return 0; 646 646 ··· 835 835 dlm_clear_members(ls); 836 836 dlm_clear_members_gone(ls); 837 837 kfree(ls->ls_node_array); 838 - log_debug(ls, "release_lockspace final free"); 838 + log_rinfo(ls, "release_lockspace final free"); 839 839 kobject_put(&ls->ls_kobj); 840 840 /* The ls structure will be freed when the kobject is done with */ 841 841
+12 -15
fs/dlm/member.c
··· 60 60 61 61 #define SLOT_DEBUG_LINE 128 62 62 63 - static void log_debug_slots(struct dlm_ls *ls, uint32_t gen, int num_slots, 64 - struct rcom_slot *ro0, struct dlm_slot *array, 65 - int array_size) 63 + static void log_slots(struct dlm_ls *ls, uint32_t gen, int num_slots, 64 + struct rcom_slot *ro0, struct dlm_slot *array, 65 + int array_size) 66 66 { 67 67 char line[SLOT_DEBUG_LINE]; 68 68 int len = SLOT_DEBUG_LINE - 1; 69 69 int pos = 0; 70 70 int ret, i; 71 - 72 - if (!dlm_config.ci_log_debug) 73 - return; 74 71 75 72 memset(line, 0, sizeof(line)); 76 73 ··· 92 95 } 93 96 } 94 97 95 - log_debug(ls, "generation %u slots %d%s", gen, num_slots, line); 98 + log_rinfo(ls, "generation %u slots %d%s", gen, num_slots, line); 96 99 } 97 100 98 101 int dlm_slots_copy_in(struct dlm_ls *ls) ··· 126 129 ro->ro_slot = le16_to_cpu(ro->ro_slot); 127 130 } 128 131 129 - log_debug_slots(ls, gen, num_slots, ro0, NULL, 0); 132 + log_slots(ls, gen, num_slots, ro0, NULL, 0); 130 133 131 134 list_for_each_entry(memb, &ls->ls_nodes, list) { 132 135 for (i = 0, ro = ro0; i < num_slots; i++, ro++) { ··· 271 274 272 275 gen++; 273 276 274 - log_debug_slots(ls, gen, num, NULL, array, array_size); 277 + log_slots(ls, gen, num, NULL, array, array_size); 275 278 276 279 max_slots = (dlm_config.ci_buffer_size - sizeof(struct dlm_rcom) - 277 280 sizeof(struct rcom_config)) / sizeof(struct rcom_slot); ··· 444 447 break; 445 448 } 446 449 if (error) 447 - log_debug(ls, "ping_members aborted %d last nodeid %d", 450 + log_rinfo(ls, "ping_members aborted %d last nodeid %d", 448 451 error, ls->ls_recover_nodeid); 449 452 return error; 450 453 } ··· 536 539 count as a negative change so the "neg" recovery steps will happen */ 537 540 538 541 list_for_each_entry(memb, &ls->ls_nodes_gone, list) { 539 - log_debug(ls, "prev removed member %d", memb->nodeid); 542 + log_rinfo(ls, "prev removed member %d", memb->nodeid); 540 543 neg++; 541 544 } 542 545 ··· 548 551 continue; 549 552 550 553 if (!node) { 551 - log_debug(ls, "remove member %d", memb->nodeid); 554 + log_rinfo(ls, "remove member %d", memb->nodeid); 552 555 } else { 553 556 /* removed and re-added */ 554 - log_debug(ls, "remove member %d comm_seq %u %u", 557 + log_rinfo(ls, "remove member %d comm_seq %u %u", 555 558 memb->nodeid, memb->comm_seq, node->comm_seq); 556 559 } 557 560 ··· 568 571 if (dlm_is_member(ls, node->nodeid)) 569 572 continue; 570 573 dlm_add_member(ls, node); 571 - log_debug(ls, "add member %d", node->nodeid); 574 + log_rinfo(ls, "add member %d", node->nodeid); 572 575 } 573 576 574 577 list_for_each_entry(memb, &ls->ls_nodes, list) { ··· 588 591 complete(&ls->ls_members_done); 589 592 } 590 593 591 - log_debug(ls, "dlm_recover_members %d nodes", ls->ls_num_nodes); 594 + log_rinfo(ls, "dlm_recover_members %d nodes", ls->ls_num_nodes); 592 595 return error; 593 596 } 594 597
+5 -5
fs/dlm/recover.c
··· 526 526 int nodir = dlm_no_directory(ls); 527 527 int error; 528 528 529 - log_debug(ls, "dlm_recover_masters"); 529 + log_rinfo(ls, "dlm_recover_masters"); 530 530 531 531 down_read(&ls->ls_root_sem); 532 532 list_for_each_entry(r, &ls->ls_root_list, res_root_list) { ··· 552 552 } 553 553 up_read(&ls->ls_root_sem); 554 554 555 - log_debug(ls, "dlm_recover_masters %u of %u", count, total); 555 + log_rinfo(ls, "dlm_recover_masters %u of %u", count, total); 556 556 557 557 error = dlm_wait_function(ls, &recover_idr_empty); 558 558 out: ··· 685 685 } 686 686 up_read(&ls->ls_root_sem); 687 687 688 - log_debug(ls, "dlm_recover_locks %d out", count); 688 + log_rinfo(ls, "dlm_recover_locks %d out", count); 689 689 690 690 error = dlm_wait_function(ls, &recover_list_empty); 691 691 out: ··· 883 883 up_read(&ls->ls_root_sem); 884 884 885 885 if (count) 886 - log_debug(ls, "dlm_recover_rsbs %d done", count); 886 + log_rinfo(ls, "dlm_recover_rsbs %d done", count); 887 887 } 888 888 889 889 /* Create a single list of all root rsb's to be used during recovery */ ··· 950 950 } 951 951 952 952 if (count) 953 - log_debug(ls, "dlm_clear_toss %u done", count); 953 + log_rinfo(ls, "dlm_clear_toss %u done", count); 954 954 } 955 955
+17 -17
fs/dlm/recoverd.c
··· 55 55 unsigned long start; 56 56 int error, neg = 0; 57 57 58 - log_debug(ls, "dlm_recover %llu", (unsigned long long)rv->seq); 58 + log_rinfo(ls, "dlm_recover %llu", (unsigned long long)rv->seq); 59 59 60 60 mutex_lock(&ls->ls_recoverd_active); 61 61 ··· 76 76 77 77 error = dlm_recover_members(ls, rv, &neg); 78 78 if (error) { 79 - log_debug(ls, "dlm_recover_members error %d", error); 79 + log_rinfo(ls, "dlm_recover_members error %d", error); 80 80 goto fail; 81 81 } 82 82 ··· 90 90 91 91 error = dlm_recover_members_wait(ls); 92 92 if (error) { 93 - log_debug(ls, "dlm_recover_members_wait error %d", error); 93 + log_rinfo(ls, "dlm_recover_members_wait error %d", error); 94 94 goto fail; 95 95 } 96 96 ··· 103 103 104 104 error = dlm_recover_directory(ls); 105 105 if (error) { 106 - log_debug(ls, "dlm_recover_directory error %d", error); 106 + log_rinfo(ls, "dlm_recover_directory error %d", error); 107 107 goto fail; 108 108 } 109 109 ··· 111 111 112 112 error = dlm_recover_directory_wait(ls); 113 113 if (error) { 114 - log_debug(ls, "dlm_recover_directory_wait error %d", error); 114 + log_rinfo(ls, "dlm_recover_directory_wait error %d", error); 115 115 goto fail; 116 116 } 117 117 118 - log_debug(ls, "dlm_recover_directory %u out %u messages", 118 + log_rinfo(ls, "dlm_recover_directory %u out %u messages", 119 119 ls->ls_recover_dir_sent_res, ls->ls_recover_dir_sent_msg); 120 120 121 121 /* ··· 144 144 145 145 error = dlm_recover_masters(ls); 146 146 if (error) { 147 - log_debug(ls, "dlm_recover_masters error %d", error); 147 + log_rinfo(ls, "dlm_recover_masters error %d", error); 148 148 goto fail; 149 149 } 150 150 ··· 154 154 155 155 error = dlm_recover_locks(ls); 156 156 if (error) { 157 - log_debug(ls, "dlm_recover_locks error %d", error); 157 + log_rinfo(ls, "dlm_recover_locks error %d", error); 158 158 goto fail; 159 159 } 160 160 ··· 162 162 163 163 error = dlm_recover_locks_wait(ls); 164 164 if (error) { 165 - log_debug(ls, "dlm_recover_locks_wait error %d", error); 165 + log_rinfo(ls, "dlm_recover_locks_wait error %d", error); 166 166 goto fail; 167 167 } 168 168 169 - log_debug(ls, "dlm_recover_locks %u in", 169 + log_rinfo(ls, "dlm_recover_locks %u in", 170 170 ls->ls_recover_locks_in); 171 171 172 172 /* ··· 186 186 187 187 error = dlm_recover_locks_wait(ls); 188 188 if (error) { 189 - log_debug(ls, "dlm_recover_locks_wait error %d", error); 189 + log_rinfo(ls, "dlm_recover_locks_wait error %d", error); 190 190 goto fail; 191 191 } 192 192 } ··· 205 205 206 206 error = dlm_recover_done_wait(ls); 207 207 if (error) { 208 - log_debug(ls, "dlm_recover_done_wait error %d", error); 208 + log_rinfo(ls, "dlm_recover_done_wait error %d", error); 209 209 goto fail; 210 210 } 211 211 ··· 217 217 218 218 error = enable_locking(ls, rv->seq); 219 219 if (error) { 220 - log_debug(ls, "enable_locking error %d", error); 220 + log_rinfo(ls, "enable_locking error %d", error); 221 221 goto fail; 222 222 } 223 223 224 224 error = dlm_process_requestqueue(ls); 225 225 if (error) { 226 - log_debug(ls, "dlm_process_requestqueue error %d", error); 226 + log_rinfo(ls, "dlm_process_requestqueue error %d", error); 227 227 goto fail; 228 228 } 229 229 230 230 error = dlm_recover_waiters_post(ls); 231 231 if (error) { 232 - log_debug(ls, "dlm_recover_waiters_post error %d", error); 232 + log_rinfo(ls, "dlm_recover_waiters_post error %d", error); 233 233 goto fail; 234 234 } 235 235 236 236 dlm_recover_grant(ls); 237 237 238 - log_debug(ls, "dlm_recover %llu generation %u done: %u ms", 238 + log_rinfo(ls, "dlm_recover %llu generation %u done: %u ms", 239 239 (unsigned long long)rv->seq, ls->ls_generation, 240 240 jiffies_to_msecs(jiffies - start)); 241 241 mutex_unlock(&ls->ls_recoverd_active); ··· 245 245 246 246 fail: 247 247 dlm_release_root_list(ls); 248 - log_debug(ls, "dlm_recover %llu error %d", 248 + log_rinfo(ls, "dlm_recover %llu error %d", 249 249 (unsigned long long)rv->seq, error); 250 250 mutex_unlock(&ls->ls_recoverd_active); 251 251 return error;