Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

NFC: Convert nfc_dev_info and nfc_dev_err to nfc_<level>

Use a more standard kernel style macro logging name.

Standardize the spacing of the "NFC: " prefix.
Add \n to uses, remove from macro.
Fix the defective uses that already had a \n.

Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>

authored by

Joe Perches and committed by
Samuel Ortiz
073a625f b4834839

+115 -122
+7 -7
drivers/nfc/nfcsim.c
··· 19 19 #include <linux/nfc.h> 20 20 #include <net/nfc/nfc.h> 21 21 22 - #define DEV_ERR(_dev, fmt, args...) nfc_dev_err(&_dev->nfc_dev->dev, \ 22 + #define DEV_ERR(_dev, fmt, args...) nfc_err(&_dev->nfc_dev->dev, \ 23 23 "%s: " fmt, __func__, ## args) 24 24 25 25 #define DEV_DBG(_dev, fmt, args...) dev_dbg(&_dev->nfc_dev->dev, \ ··· 143 143 144 144 remote_gb = nfc_get_local_general_bytes(peer->nfc_dev, &remote_gb_len); 145 145 if (!remote_gb) { 146 - DEV_ERR(peer, "Can't get remote general bytes"); 146 + DEV_ERR(peer, "Can't get remote general bytes\n"); 147 147 148 148 mutex_unlock(&peer->lock); 149 149 return -EINVAL; ··· 155 155 156 156 rc = nfc_set_remote_general_bytes(nfc_dev, remote_gb, remote_gb_len); 157 157 if (rc) { 158 - DEV_ERR(dev, "Can't set remote general bytes"); 158 + DEV_ERR(dev, "Can't set remote general bytes\n"); 159 159 mutex_unlock(&dev->lock); 160 160 return rc; 161 161 } ··· 188 188 mutex_lock(&dev->lock); 189 189 190 190 if (dev->polling_mode != NFCSIM_POLL_NONE) { 191 - DEV_ERR(dev, "Already in polling mode"); 191 + DEV_ERR(dev, "Already in polling mode\n"); 192 192 rc = -EBUSY; 193 193 goto exit; 194 194 } ··· 200 200 dev->polling_mode |= NFCSIM_POLL_TARGET; 201 201 202 202 if (dev->polling_mode == NFCSIM_POLL_NONE) { 203 - DEV_ERR(dev, "Unsupported polling mode"); 203 + DEV_ERR(dev, "Unsupported polling mode\n"); 204 204 rc = -EINVAL; 205 205 goto exit; 206 206 } ··· 267 267 268 268 if (dev->initiator) { 269 269 if (!dev->cb) { 270 - DEV_ERR(dev, "Null recv callback"); 270 + DEV_ERR(dev, "Null recv callback\n"); 271 271 dev_kfree_skb(dev->clone_skb); 272 272 goto exit; 273 273 } ··· 310 310 peer->clone_skb = skb_clone(skb, GFP_KERNEL); 311 311 312 312 if (!peer->clone_skb) { 313 - DEV_ERR(dev, "skb_clone failed"); 313 + DEV_ERR(dev, "skb_clone failed\n"); 314 314 mutex_unlock(&peer->lock); 315 315 err = -ENOMEM; 316 316 goto exit;
+21 -23
drivers/nfc/nfcwilink.c
··· 149 149 skb = nfcwilink_skb_alloc(sizeof(struct nci_vs_nfcc_info_cmd), 150 150 GFP_KERNEL); 151 151 if (!skb) { 152 - nfc_dev_err(&drv->pdev->dev, 153 - "no memory for nci_vs_nfcc_info_cmd"); 152 + nfc_err(&drv->pdev->dev, 153 + "no memory for nci_vs_nfcc_info_cmd\n"); 154 154 return -ENOMEM; 155 155 } 156 156 ··· 180 180 drv->nfcc_info.plen, drv->nfcc_info.status); 181 181 182 182 if ((drv->nfcc_info.plen != 5) || (drv->nfcc_info.status != 0)) { 183 - nfc_dev_err(&drv->pdev->dev, 184 - "invalid nci_vs_nfcc_info_rsp"); 183 + nfc_err(&drv->pdev->dev, "invalid nci_vs_nfcc_info_rsp\n"); 185 184 return -EINVAL; 186 185 } 187 186 ··· 191 192 drv->nfcc_info.sw_ver_z, 192 193 drv->nfcc_info.patch_id); 193 194 194 - nfc_dev_info(&drv->pdev->dev, "nfcwilink FW file name: %s", file_name); 195 + nfc_info(&drv->pdev->dev, "nfcwilink FW file name: %s\n", file_name); 195 196 196 197 return 0; 197 198 } ··· 208 209 (len > BTS_FILE_CMD_MAX_LEN) || 209 210 (hdr->chnl != NFCWILINK_CHNL) || 210 211 (hdr->opcode != NFCWILINK_OPCODE)) { 211 - nfc_dev_err(&drv->pdev->dev, 212 - "ignoring invalid bts cmd, len %d, chnl %d, opcode %d", 212 + nfc_err(&drv->pdev->dev, 213 + "ignoring invalid bts cmd, len %d, chnl %d, opcode %d\n", 213 214 len, hdr->chnl, hdr->opcode); 214 215 return 0; 215 216 } ··· 220 221 221 222 skb = nfcwilink_skb_alloc(len, GFP_KERNEL); 222 223 if (!skb) { 223 - nfc_dev_err(&drv->pdev->dev, "no memory for bts cmd"); 224 + nfc_err(&drv->pdev->dev, "no memory for bts cmd\n"); 224 225 return -ENOMEM; 225 226 } 226 227 ··· 235 236 dev_dbg(&drv->pdev->dev, "wait_for_completion_timeout returned %ld\n", 236 237 comp_ret); 237 238 if (comp_ret == 0) { 238 - nfc_dev_err(&drv->pdev->dev, 239 - "timeout on wait_for_completion_timeout"); 239 + nfc_err(&drv->pdev->dev, 240 + "timeout on wait_for_completion_timeout\n"); 240 241 return -ETIMEDOUT; 241 242 } 242 243 ··· 259 260 260 261 rc = request_firmware(&fw, file_name, &drv->pdev->dev); 261 262 if (rc) { 262 - nfc_dev_err(&drv->pdev->dev, "request_firmware failed %d", rc); 263 + nfc_err(&drv->pdev->dev, "request_firmware failed %d\n", rc); 263 264 264 265 /* if the file is not found, don't exit with failure */ 265 266 if (rc == -ENOENT) ··· 279 280 280 281 if (__le32_to_cpu(((struct bts_file_hdr *)ptr)->magic) != 281 282 BTS_FILE_HDR_MAGIC) { 282 - nfc_dev_err(&drv->pdev->dev, "wrong bts magic number"); 283 + nfc_err(&drv->pdev->dev, "wrong bts magic number\n"); 283 284 rc = -EINVAL; 284 285 goto release_fw; 285 286 } ··· 360 361 /* Forward skb to NCI core layer */ 361 362 rc = nci_recv_frame(drv->ndev, skb); 362 363 if (rc < 0) { 363 - nfc_dev_err(&drv->pdev->dev, "nci_recv_frame failed %d", rc); 364 + nfc_err(&drv->pdev->dev, "nci_recv_frame failed %d\n", rc); 364 365 return rc; 365 366 } 366 367 ··· 413 414 goto clear_exit; 414 415 } else if (drv->st_register_cb_status != 0) { 415 416 rc = drv->st_register_cb_status; 416 - nfc_dev_err(&drv->pdev->dev, 417 - "st_register_cb failed %d", rc); 417 + nfc_err(&drv->pdev->dev, 418 + "st_register_cb failed %d\n", rc); 418 419 goto clear_exit; 419 420 } 420 421 } else { 421 - nfc_dev_err(&drv->pdev->dev, 422 - "st_register failed %d", rc); 422 + nfc_err(&drv->pdev->dev, "st_register failed %d\n", rc); 423 423 goto clear_exit; 424 424 } 425 425 } ··· 428 430 drv->st_write = nfcwilink_proto.write; 429 431 430 432 if (nfcwilink_download_fw(drv)) { 431 - nfc_dev_err(&drv->pdev->dev, "nfcwilink_download_fw failed %d", 432 - rc); 433 + nfc_err(&drv->pdev->dev, "nfcwilink_download_fw failed %d\n", 434 + rc); 433 435 /* open should succeed, even if the FW download failed */ 434 436 } 435 437 ··· 452 454 453 455 rc = st_unregister(&nfcwilink_proto); 454 456 if (rc) 455 - nfc_dev_err(&drv->pdev->dev, "st_unregister failed %d", rc); 457 + nfc_err(&drv->pdev->dev, "st_unregister failed %d\n", rc); 456 458 457 459 drv->st_write = NULL; 458 460 ··· 483 485 len = drv->st_write(skb); 484 486 if (len < 0) { 485 487 kfree_skb(skb); 486 - nfc_dev_err(&drv->pdev->dev, "st_write failed %ld", len); 488 + nfc_err(&drv->pdev->dev, "st_write failed %ld\n", len); 487 489 return -EFAULT; 488 490 } 489 491 ··· 521 523 NFCWILINK_HDR_LEN, 522 524 0); 523 525 if (!drv->ndev) { 524 - nfc_dev_err(&pdev->dev, "nci_allocate_device failed"); 526 + nfc_err(&pdev->dev, "nci_allocate_device failed\n"); 525 527 rc = -ENOMEM; 526 528 goto exit; 527 529 } ··· 531 533 532 534 rc = nci_register_device(drv->ndev); 533 535 if (rc < 0) { 534 - nfc_dev_err(&pdev->dev, "nci_register_device failed %d", rc); 536 + nfc_err(&pdev->dev, "nci_register_device failed %d\n", rc); 535 537 goto free_dev_exit; 536 538 } 537 539
+85 -90
drivers/nfc/pn533.c
··· 728 728 goto sched_wq; 729 729 case -ESHUTDOWN: 730 730 default: 731 - nfc_dev_err(&dev->interface->dev, 732 - "Urb failure (status %d)", urb->status); 731 + nfc_err(&dev->interface->dev, 732 + "Urb failure (status %d)\n", urb->status); 733 733 goto sched_wq; 734 734 } 735 735 ··· 740 740 dev->ops->rx_frame_size(in_frame), false); 741 741 742 742 if (!dev->ops->rx_is_frame_valid(in_frame, dev)) { 743 - nfc_dev_err(&dev->interface->dev, "Received an invalid frame"); 743 + nfc_err(&dev->interface->dev, "Received an invalid frame\n"); 744 744 cmd->status = -EIO; 745 745 goto sched_wq; 746 746 } 747 747 748 748 if (!pn533_rx_frame_is_cmd_response(dev, in_frame)) { 749 - nfc_dev_err(&dev->interface->dev, 750 - "It it not the response to the last command"); 749 + nfc_err(&dev->interface->dev, 750 + "It it not the response to the last command\n"); 751 751 cmd->status = -EIO; 752 752 goto sched_wq; 753 753 } ··· 783 783 goto sched_wq; 784 784 case -ESHUTDOWN: 785 785 default: 786 - nfc_dev_err(&dev->interface->dev, 787 - "Urb failure (status %d)", urb->status); 786 + nfc_err(&dev->interface->dev, 787 + "Urb failure (status %d)\n", urb->status); 788 788 goto sched_wq; 789 789 } 790 790 791 791 in_frame = dev->in_urb->transfer_buffer; 792 792 793 793 if (!pn533_std_rx_frame_is_ack(in_frame)) { 794 - nfc_dev_err(&dev->interface->dev, "Received an invalid ack"); 794 + nfc_err(&dev->interface->dev, "Received an invalid ack\n"); 795 795 cmd->status = -EIO; 796 796 goto sched_wq; 797 797 } 798 798 799 799 rc = pn533_submit_urb_for_response(dev, GFP_ATOMIC); 800 800 if (rc) { 801 - nfc_dev_err(&dev->interface->dev, 802 - "usb_submit_urb failed with result %d", rc); 801 + nfc_err(&dev->interface->dev, 802 + "usb_submit_urb failed with result %d\n", rc); 803 803 cmd->status = rc; 804 804 goto sched_wq; 805 805 } ··· 1172 1172 break; 1173 1173 case -ESHUTDOWN: 1174 1174 default: 1175 - nfc_dev_err(&dev->interface->dev, 1176 - "Urb failure (status %d)", urb->status); 1175 + nfc_err(&dev->interface->dev, "Urb failure (status %d)\n", 1176 + urb->status); 1177 1177 } 1178 1178 } 1179 1179 ··· 1473 1473 rc = pn533_target_found_type_b(&nfc_tgt, tgdata, tgdata_len); 1474 1474 break; 1475 1475 default: 1476 - nfc_dev_err(&dev->interface->dev, 1477 - "Unknown current poll modulation"); 1476 + nfc_err(&dev->interface->dev, 1477 + "Unknown current poll modulation\n"); 1478 1478 return -EPROTO; 1479 1479 } 1480 1480 ··· 1695 1695 rc = nfc_tm_activated(dev->nfc_dev, NFC_PROTO_NFC_DEP_MASK, 1696 1696 comm_mode, gb, gb_len); 1697 1697 if (rc < 0) { 1698 - nfc_dev_err(&dev->interface->dev, 1699 - "Error when signaling target activation"); 1698 + nfc_err(&dev->interface->dev, 1699 + "Error when signaling target activation\n"); 1700 1700 return rc; 1701 1701 } 1702 1702 ··· 1730 1730 if (IS_ERR(resp)) { 1731 1731 rc = PTR_ERR(resp); 1732 1732 1733 - nfc_dev_err(&dev->interface->dev, "%s RF setting error %d", 1734 - __func__, rc); 1733 + nfc_err(&dev->interface->dev, "RF setting error %d", rc); 1735 1734 1736 1735 return rc; 1737 1736 } ··· 1761 1762 pn533_rf_complete, NULL); 1762 1763 if (rc < 0) { 1763 1764 dev_kfree_skb(skb); 1764 - nfc_dev_err(&dev->interface->dev, "RF setting error %d", rc); 1765 + nfc_err(&dev->interface->dev, "RF setting error %d\n", rc); 1765 1766 } 1766 1767 1767 1768 return; ··· 1778 1779 if (IS_ERR(resp)) { 1779 1780 rc = PTR_ERR(resp); 1780 1781 1781 - nfc_dev_err(&dev->interface->dev, "%s Poll complete error %d", 1782 - __func__, rc); 1782 + nfc_err(&dev->interface->dev, "%s Poll complete error %d\n", 1783 + __func__, rc); 1783 1784 1784 1785 if (rc == -ENOENT) { 1785 1786 if (dev->poll_mod_count != 0) ··· 1787 1788 else 1788 1789 goto stop_poll; 1789 1790 } else if (rc < 0) { 1790 - nfc_dev_err(&dev->interface->dev, 1791 - "Error %d when running poll", rc); 1791 + nfc_err(&dev->interface->dev, 1792 + "Error %d when running poll\n", rc); 1792 1793 goto stop_poll; 1793 1794 } 1794 1795 } ··· 1820 1821 return rc; 1821 1822 1822 1823 stop_poll: 1823 - nfc_dev_err(&dev->interface->dev, "Polling operation has been stopped"); 1824 + nfc_err(&dev->interface->dev, "Polling operation has been stopped\n"); 1824 1825 1825 1826 pn533_poll_reset_mod_list(dev); 1826 1827 dev->poll_protocols = 0; ··· 1862 1863 } 1863 1864 1864 1865 if (!skb) { 1865 - nfc_dev_err(&dev->interface->dev, "Failed to allocate skb."); 1866 + nfc_err(&dev->interface->dev, "Failed to allocate skb\n"); 1866 1867 return -ENOMEM; 1867 1868 } 1868 1869 ··· 1870 1871 NULL); 1871 1872 if (rc < 0) { 1872 1873 dev_kfree_skb(skb); 1873 - nfc_dev_err(&dev->interface->dev, "Polling loop error %d", rc); 1874 + nfc_err(&dev->interface->dev, "Polling loop error %d\n", rc); 1874 1875 } 1875 1876 1876 1877 return rc; ··· 1914 1915 __func__, im_protocols, tm_protocols); 1915 1916 1916 1917 if (dev->tgt_active_prot) { 1917 - nfc_dev_err(&dev->interface->dev, 1918 - "Cannot poll with a target already activated"); 1918 + nfc_err(&dev->interface->dev, 1919 + "Cannot poll with a target already activated\n"); 1919 1920 return -EBUSY; 1920 1921 } 1921 1922 1922 1923 if (dev->tgt_mode) { 1923 - nfc_dev_err(&dev->interface->dev, 1924 - "Cannot poll while already being activated"); 1924 + nfc_err(&dev->interface->dev, 1925 + "Cannot poll while already being activated\n"); 1925 1926 return -EBUSY; 1926 1927 } 1927 1928 ··· 1984 1985 rsp = (struct pn533_cmd_activate_response *)resp->data; 1985 1986 rc = rsp->status & PN533_CMD_RET_MASK; 1986 1987 if (rc != PN533_CMD_RET_SUCCESS) { 1987 - nfc_dev_err(&dev->interface->dev, 1988 - "Target activation failed (error 0x%x)", rc); 1988 + nfc_err(&dev->interface->dev, 1989 + "Target activation failed (error 0x%x)\n", rc); 1989 1990 dev_kfree_skb(resp); 1990 1991 return -EIO; 1991 1992 } ··· 2008 2009 __func__, protocol); 2009 2010 2010 2011 if (dev->poll_mod_count) { 2011 - dev_err(&dev->interface->dev, 2012 + nfc_err(&dev->interface->dev, 2012 2013 "Cannot activate while polling\n"); 2013 2014 return -EBUSY; 2014 2015 } 2015 2016 2016 2017 if (dev->tgt_active_prot) { 2017 - nfc_dev_err(&dev->interface->dev, 2018 - "There is already an active target"); 2018 + nfc_err(&dev->interface->dev, 2019 + "There is already an active target\n"); 2019 2020 return -EBUSY; 2020 2021 } 2021 2022 2022 2023 if (!dev->tgt_available_prots) { 2023 - nfc_dev_err(&dev->interface->dev, 2024 - "There is no available target to activate"); 2024 + nfc_err(&dev->interface->dev, 2025 + "There is no available target to activate\n"); 2025 2026 return -EINVAL; 2026 2027 } 2027 2028 2028 2029 if (!(dev->tgt_available_prots & (1 << protocol))) { 2029 - nfc_dev_err(&dev->interface->dev, 2030 - "Target doesn't support requested proto %u", 2031 - protocol); 2030 + nfc_err(&dev->interface->dev, 2031 + "Target doesn't support requested proto %u\n", 2032 + protocol); 2032 2033 return -EINVAL; 2033 2034 } 2034 2035 2035 2036 if (protocol == NFC_PROTO_NFC_DEP) { 2036 2037 rc = pn533_activate_target_nfcdep(dev); 2037 2038 if (rc) { 2038 - nfc_dev_err(&dev->interface->dev, 2039 - "Activating target with DEP failed %d", rc); 2039 + nfc_err(&dev->interface->dev, 2040 + "Activating target with DEP failed %d\n", rc); 2040 2041 return rc; 2041 2042 } 2042 2043 } ··· 2058 2059 dev_dbg(&dev->interface->dev, "%s\n", __func__); 2059 2060 2060 2061 if (!dev->tgt_active_prot) { 2061 - nfc_dev_err(&dev->interface->dev, "There is no active target"); 2062 + nfc_err(&dev->interface->dev, "There is no active target\n"); 2062 2063 return; 2063 2064 } 2064 2065 ··· 2077 2078 2078 2079 rc = resp->data[0] & PN533_CMD_RET_MASK; 2079 2080 if (rc != PN533_CMD_RET_SUCCESS) 2080 - nfc_dev_err(&dev->interface->dev, 2081 - "Error 0x%x when releasing the target", rc); 2081 + nfc_err(&dev->interface->dev, 2082 + "Error 0x%x when releasing the target\n", rc); 2082 2083 2083 2084 dev_kfree_skb(resp); 2084 2085 return; ··· 2100 2101 2101 2102 if (dev->tgt_available_prots && 2102 2103 !(dev->tgt_available_prots & (1 << NFC_PROTO_NFC_DEP))) { 2103 - nfc_dev_err(&dev->interface->dev, 2104 - "The target does not support DEP"); 2104 + nfc_err(&dev->interface->dev, 2105 + "The target does not support DEP\n"); 2105 2106 rc = -EINVAL; 2106 2107 goto error; 2107 2108 } ··· 2110 2111 2111 2112 rc = rsp->status & PN533_CMD_RET_MASK; 2112 2113 if (rc != PN533_CMD_RET_SUCCESS) { 2113 - nfc_dev_err(&dev->interface->dev, 2114 - "Bringing DEP link up failed (error 0x%x)", rc); 2114 + nfc_err(&dev->interface->dev, 2115 + "Bringing DEP link up failed (error 0x%x)\n", rc); 2115 2116 goto error; 2116 2117 } 2117 2118 ··· 2160 2161 dev_dbg(&dev->interface->dev, "%s\n", __func__); 2161 2162 2162 2163 if (dev->poll_mod_count) { 2163 - nfc_dev_err(&dev->interface->dev, 2164 - "Cannot bring the DEP link up while polling"); 2164 + nfc_err(&dev->interface->dev, 2165 + "Cannot bring the DEP link up while polling\n"); 2165 2166 return -EBUSY; 2166 2167 } 2167 2168 2168 2169 if (dev->tgt_active_prot) { 2169 - nfc_dev_err(&dev->interface->dev, 2170 - "There is already an active target"); 2170 + nfc_err(&dev->interface->dev, 2171 + "There is already an active target\n"); 2171 2172 return -EBUSY; 2172 2173 } 2173 2174 ··· 2317 2318 skb_pull(resp, sizeof(status)); 2318 2319 2319 2320 if (ret != PN533_CMD_RET_SUCCESS) { 2320 - nfc_dev_err(&dev->interface->dev, 2321 - "Exchanging data failed (error 0x%x)", ret); 2321 + nfc_err(&dev->interface->dev, 2322 + "Exchanging data failed (error 0x%x)\n", ret); 2322 2323 rc = -EIO; 2323 2324 goto error; 2324 2325 } ··· 2411 2412 dev_dbg(&dev->interface->dev, "%s\n", __func__); 2412 2413 2413 2414 if (!dev->tgt_active_prot) { 2414 - nfc_dev_err(&dev->interface->dev, 2415 - "Can't exchange data if there is no active target"); 2415 + nfc_err(&dev->interface->dev, 2416 + "Can't exchange data if there is no active target\n"); 2416 2417 rc = -EINVAL; 2417 2418 goto error; 2418 2419 } ··· 2505 2506 dev_dbg(&dev->interface->dev, "%s\n", __func__); 2506 2507 2507 2508 if (skb->len > PN533_CMD_DATAEXCH_DATA_MAXLEN) { 2508 - nfc_dev_err(&dev->interface->dev, 2509 - "Data length greater than the max allowed: %d", 2510 - PN533_CMD_DATAEXCH_DATA_MAXLEN); 2509 + nfc_err(&dev->interface->dev, 2510 + "Data length greater than the max allowed: %d\n", 2511 + PN533_CMD_DATAEXCH_DATA_MAXLEN); 2511 2512 return -ENOSYS; 2512 2513 } 2513 2514 ··· 2557 2558 if (rc == 0) /* success */ 2558 2559 return; 2559 2560 2560 - nfc_dev_err(&dev->interface->dev, 2561 - "Error %d when trying to perform data_exchange", rc); 2561 + nfc_err(&dev->interface->dev, 2562 + "Error %d when trying to perform data_exchange\n", rc); 2562 2563 2563 2564 dev_kfree_skb(skb); 2564 2565 kfree(dev->cmd_complete_mi_arg); ··· 2612 2613 if (rc == 0) /* success */ 2613 2614 return; 2614 2615 2615 - nfc_dev_err(&dev->interface->dev, 2616 - "Error %d when trying to perform data_exchange", rc); 2616 + nfc_err(&dev->interface->dev, 2617 + "Error %d when trying to perform data_exchange\n", rc); 2617 2618 2618 2619 dev_kfree_skb(skb); 2619 2620 kfree(dev->cmd_complete_dep_arg); ··· 2741 2742 2742 2743 rc = usb_submit_urb(dev->out_urb, GFP_KERNEL); 2743 2744 if (rc) { 2744 - nfc_dev_err(&dev->interface->dev, 2745 - "Reader power on cmd error %d", rc); 2745 + nfc_err(&dev->interface->dev, 2746 + "Reader power on cmd error %d\n", rc); 2746 2747 return rc; 2747 2748 } 2748 2749 2749 2750 rc = usb_submit_urb(dev->in_urb, GFP_KERNEL); 2750 2751 if (rc) { 2751 - nfc_dev_err(&dev->interface->dev, 2752 - "Can't submit for reader power on cmd response %d", 2753 - rc); 2752 + nfc_err(&dev->interface->dev, 2753 + "Can't submit reader poweron cmd response %d\n", rc); 2754 2754 return rc; 2755 2755 } 2756 2756 ··· 2770 2772 rc = pn533_set_configuration(dev, PN533_CFGITEM_RF_FIELD, 2771 2773 (u8 *)&rf_field, 1); 2772 2774 if (rc) { 2773 - nfc_dev_err(&dev->interface->dev, 2774 - "Error on setting RF field"); 2775 + nfc_err(&dev->interface->dev, "Error on setting RF field\n"); 2775 2776 return rc; 2776 2777 } 2777 2778 ··· 2823 2826 break; 2824 2827 2825 2828 default: 2826 - nfc_dev_err(&dev->interface->dev, "Unknown device type %d\n", 2827 - dev->device_type); 2829 + nfc_err(&dev->interface->dev, "Unknown device type %d\n", 2830 + dev->device_type); 2828 2831 return -EINVAL; 2829 2832 } 2830 2833 2831 2834 rc = pn533_set_configuration(dev, PN533_CFGITEM_MAX_RETRIES, 2832 2835 (u8 *)&max_retries, sizeof(max_retries)); 2833 2836 if (rc) { 2834 - nfc_dev_err(&dev->interface->dev, 2835 - "Error on setting MAX_RETRIES config"); 2837 + nfc_err(&dev->interface->dev, 2838 + "Error on setting MAX_RETRIES config\n"); 2836 2839 return rc; 2837 2840 } 2838 2841 ··· 2840 2843 rc = pn533_set_configuration(dev, PN533_CFGITEM_TIMING, 2841 2844 (u8 *)&timing, sizeof(timing)); 2842 2845 if (rc) { 2843 - nfc_dev_err(&dev->interface->dev, 2844 - "Error on setting RF timings"); 2846 + nfc_err(&dev->interface->dev, "Error on setting RF timings\n"); 2845 2847 return rc; 2846 2848 } 2847 2849 ··· 2854 2858 rc = pn533_set_configuration(dev, PN533_CFGITEM_PASORI, 2855 2859 pasori_cfg, 3); 2856 2860 if (rc) { 2857 - nfc_dev_err(&dev->interface->dev, 2858 - "Error while settings PASORI config"); 2861 + nfc_err(&dev->interface->dev, 2862 + "Error while settings PASORI config\n"); 2859 2863 return rc; 2860 2864 } 2861 2865 ··· 2900 2904 } 2901 2905 2902 2906 if (!in_endpoint || !out_endpoint) { 2903 - nfc_dev_err(&interface->dev, 2904 - "Could not find bulk-in or bulk-out endpoint"); 2907 + nfc_err(&interface->dev, 2908 + "Could not find bulk-in or bulk-out endpoint\n"); 2905 2909 rc = -ENODEV; 2906 2910 goto error; 2907 2911 } ··· 2961 2965 2962 2966 rc = pn533_acr122_poweron_rdr(dev); 2963 2967 if (rc < 0) { 2964 - nfc_dev_err(&dev->interface->dev, 2965 - "Couldn't poweron the reader (error %d)", 2966 - rc); 2968 + nfc_err(&dev->interface->dev, 2969 + "Couldn't poweron the reader (error %d)\n", rc); 2967 2970 goto destroy_wq; 2968 2971 } 2969 2972 break; 2970 2973 2971 2974 default: 2972 - nfc_dev_err(&dev->interface->dev, "Unknown device type %d\n", 2973 - dev->device_type); 2975 + nfc_err(&dev->interface->dev, "Unknown device type %d\n", 2976 + dev->device_type); 2974 2977 rc = -EINVAL; 2975 2978 goto destroy_wq; 2976 2979 } ··· 2979 2984 if (rc < 0) 2980 2985 goto destroy_wq; 2981 2986 2982 - nfc_dev_info(&dev->interface->dev, 2983 - "NXP PN5%02X firmware ver %d.%d now attached", 2984 - fw_ver.ic, fw_ver.ver, fw_ver.rev); 2987 + nfc_info(&dev->interface->dev, 2988 + "NXP PN5%02X firmware ver %d.%d now attached\n", 2989 + fw_ver.ic, fw_ver.ver, fw_ver.rev); 2985 2990 2986 2991 2987 2992 dev->nfc_dev = nfc_allocate_device(&pn533_nfc_ops, protocols, ··· 3052 3057 usb_free_urb(dev->out_urb); 3053 3058 kfree(dev); 3054 3059 3055 - nfc_dev_info(&interface->dev, "NXP PN533 NFC device disconnected"); 3060 + nfc_info(&interface->dev, "NXP PN533 NFC device disconnected\n"); 3056 3061 } 3057 3062 3058 3063 static struct usb_driver pn533_driver = {
+2 -2
include/net/nfc/nfc.h
··· 28 28 #include <linux/device.h> 29 29 #include <linux/skbuff.h> 30 30 31 - #define nfc_dev_info(dev, fmt, arg...) dev_info((dev), "NFC: " fmt "\n", ## arg) 32 - #define nfc_dev_err(dev, fmt, arg...) dev_err((dev), "NFC: " fmt "\n", ## arg) 31 + #define nfc_info(dev, fmt, ...) dev_info((dev), "NFC: " fmt, ##__VA_ARGS__) 32 + #define nfc_err(dev, fmt, ...) dev_err((dev), "NFC: " fmt, ##__VA_ARGS__) 33 33 34 34 struct nfc_dev; 35 35