Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

leds: rgb: leds-qcom-lpg: Don't enable TRILED when configuring PWM

The PWM signal from the LPG channel can be routed to PMIC GPIOs with
proper GPIO configuration, and it is not necessary to enable the
TRILED channel in that case. This also applies to the LPG channels
that mapped to TRILED channels. Additionally, enabling the TRILED
channel unnecessarily would cause a voltage increase in its power
supply. Hence remove it.

Fixes: 24e2d05d1b68 ("leds: Add driver for Qualcomm LPG")
Signed-off-by: Fenglin Wu <fenglin.wu@oss.qualcomm.com>
Reviewed-by: Bjorn Andersson <andersson@kernel.org>
Link: https://patch.msgid.link/20251119-lpg_triled_fix-v3-2-84b6dbdc774a@oss.qualcomm.com
Signed-off-by: Lee Jones <lee@kernel.org>

authored by

Fenglin Wu and committed by
Lee Jones
072cd5f4 5d390e7a

+1 -3
+1 -3
drivers/leds/rgb/leds-qcom-lpg.c
··· 2 2 /* 3 3 * Copyright (c) 2017-2022 Linaro Ltd 4 4 * Copyright (c) 2010-2012, The Linux Foundation. All rights reserved. 5 - * Copyright (c) 2023-2024, Qualcomm Innovation Center, Inc. All rights reserved. 5 + * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries. 6 6 */ 7 7 #include <linux/bits.h> 8 8 #include <linux/bitfield.h> ··· 1246 1246 chan->enabled = state->enabled; 1247 1247 1248 1248 lpg_apply(chan); 1249 - 1250 - triled_set(lpg, chan->triled_mask, chan->enabled ? chan->triled_mask : 0); 1251 1249 1252 1250 out_unlock: 1253 1251 mutex_unlock(&lpg->lock);