Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

mmc: mtk-sd: replace use of system_wq with system_percpu_wq

Currently if a user enqueues a work item using schedule_delayed_work() the
used wq is "system_wq" (per-cpu wq) while queue_delayed_work() use
WORK_CPU_UNBOUND (used when a cpu is not specified). The same applies to
schedule_work() that is using system_wq and queue_work(), that makes use
again of WORK_CPU_UNBOUND.

This lack of consistency cannot be addressed without refactoring the API.

This patch continues the effort to refactor worqueue APIs, which has begun
with the change introducing new workqueues and a new alloc_workqueue flag:

commit 128ea9f6ccfb ("workqueue: Add system_percpu_wq and system_dfl_wq")
commit 930c2ea566af ("workqueue: Add new WQ_PERCPU flag")

Replace system_wq with system_percpu_wq, keeping the same old behavior.
The old wq (system_wq) will be kept for a few release cycles.

Suggested-by: Tejun Heo <tj@kernel.org>
Signed-off-by: Marco Crivellari <marco.crivellari@suse.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>

authored by

Marco Crivellari and committed by
Ulf Hansson
070f0336 5f87aaf5

+2 -2
+2 -2
drivers/mmc/host/mtk-sd.c
··· 1214 1214 host->data = data; 1215 1215 read = data->flags & MMC_DATA_READ; 1216 1216 1217 - mod_delayed_work(system_wq, &host->req_timeout, DAT_TIMEOUT); 1217 + mod_delayed_work(system_percpu_wq, &host->req_timeout, DAT_TIMEOUT); 1218 1218 msdc_dma_setup(host, &host->dma, data); 1219 1219 sdr_set_bits(host->base + MSDC_INTEN, data_ints_mask); 1220 1220 sdr_set_field(host->base + MSDC_DMA_CTRL, MSDC_DMA_CTRL_START, 1); ··· 1444 1444 WARN_ON(host->cmd); 1445 1445 host->cmd = cmd; 1446 1446 1447 - mod_delayed_work(system_wq, &host->req_timeout, DAT_TIMEOUT); 1447 + mod_delayed_work(system_percpu_wq, &host->req_timeout, DAT_TIMEOUT); 1448 1448 if (!msdc_cmd_is_ready(host, mrq, cmd)) 1449 1449 return; 1450 1450