Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

[media] media drivers: annotate fall-through

Avoid warnings like those:

drivers/media/pci/ddbridge/ddbridge-core.c: In function 'dvb_input_detach':
drivers/media/pci/ddbridge/ddbridge-core.c:787:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
if (input->fe) {
^
drivers/media/pci/ddbridge/ddbridge-core.c:792:2: note: here
case 4:
^~~~
...

On several cases, it is just that gcc 7.1 is not capable of
understanding the comment, but on other places, we need an
annotation.

Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>

+117 -58
+1
drivers/media/dvb-frontends/af9013.c
··· 535 535 switch (state->statistics_step) { 536 536 default: 537 537 state->statistics_step = 0; 538 + /* fall-through */ 538 539 case 0: 539 540 af9013_statistics_signal_strength(&state->fe); 540 541 state->statistics_step++;
+2 -1
drivers/media/dvb-frontends/bcm3510.c
··· 773 773 deb_info("attempting to download firmware\n"); 774 774 if ((ret = bcm3510_init_cold(st)) < 0) 775 775 return ret; 776 - case JDEC_EEPROM_LOAD_WAIT: /* fall-through is wanted */ 776 + /* fall-through */ 777 + case JDEC_EEPROM_LOAD_WAIT: 777 778 deb_info("firmware is loaded\n"); 778 779 bcm3510_check_firmware_version(st); 779 780 break;
+3 -3
drivers/media/dvb-frontends/dib7000p.c
··· 279 279 if (state->version != SOC7090) 280 280 reg_1280 &= ~((1 << 11)); 281 281 reg_1280 &= ~(1 << 6); 282 - /* fall through wanted to enable the interfaces */ 283 - 282 + /* fall-through */ 283 + case DIB7000P_POWER_INTERFACE_ONLY: 284 284 /* just leave power on the control-interfaces: GPIO and (I2C or SDIO) */ 285 - case DIB7000P_POWER_INTERFACE_ONLY: /* TODO power up either SDIO or I2C */ 285 + /* TODO power up either SDIO or I2C */ 286 286 if (state->version == SOC7090) 287 287 reg_1280 &= ~((1 << 7) | (1 << 5)); 288 288 else
+11 -9
drivers/media/dvb-frontends/drx39xyj/drxj.c
··· 2837 2837 /* coef = 188/204 */ 2838 2838 max_bit_rate = 2839 2839 (ext_attr->curr_symbol_rate / 8) * nr_bits * 188; 2840 - /* pass through b/c Annex A/c need following settings */ 2840 + /* pass through as b/c Annex A/c need following settings */ 2841 + /* fall-through */ 2841 2842 case DRX_STANDARD_ITU_B: 2842 2843 rc = drxj_dap_write_reg16(dev_addr, FEC_OC_FCT_USAGE__A, FEC_OC_FCT_USAGE__PRE, 0); 2843 2844 if (rc != 0) { ··· 4777 4776 No need to account for mirroring on RF 4778 4777 */ 4779 4778 switch (ext_attr->standard) { 4780 - case DRX_STANDARD_ITU_A: /* fallthrough */ 4781 - case DRX_STANDARD_ITU_C: /* fallthrough */ 4782 - case DRX_STANDARD_PAL_SECAM_LP: /* fallthrough */ 4779 + case DRX_STANDARD_ITU_A: 4780 + case DRX_STANDARD_ITU_C: 4781 + case DRX_STANDARD_PAL_SECAM_LP: 4783 4782 case DRX_STANDARD_8VSB: 4784 4783 select_pos_image = true; 4785 4784 break; ··· 4788 4787 Sound carrier is already 3Mhz above centre frequency due 4789 4788 to tuner setting so now add an extra shift of 1MHz... */ 4790 4789 fm_frequency_shift = 1000; 4791 - case DRX_STANDARD_ITU_B: /* fallthrough */ 4792 - case DRX_STANDARD_NTSC: /* fallthrough */ 4793 - case DRX_STANDARD_PAL_SECAM_BG: /* fallthrough */ 4794 - case DRX_STANDARD_PAL_SECAM_DK: /* fallthrough */ 4795 - case DRX_STANDARD_PAL_SECAM_I: /* fallthrough */ 4790 + /*fall through */ 4791 + case DRX_STANDARD_ITU_B: 4792 + case DRX_STANDARD_NTSC: 4793 + case DRX_STANDARD_PAL_SECAM_BG: 4794 + case DRX_STANDARD_PAL_SECAM_DK: 4795 + case DRX_STANDARD_PAL_SECAM_I: 4796 4796 case DRX_STANDARD_PAL_SECAM_L: 4797 4797 select_pos_image = false; 4798 4798 break;
+7 -3
drivers/media/dvb-frontends/drxd_hard.c
··· 1517 1517 switch (deviceId) { 1518 1518 case 4: 1519 1519 state->diversity = 1; 1520 + /* fall through */ 1520 1521 case 3: 1521 1522 case 7: 1522 1523 state->PGA = 1; 1523 1524 break; 1524 1525 case 6: 1525 1526 state->diversity = 1; 1527 + /* fall through */ 1526 1528 case 5: 1527 1529 case 8: 1528 1530 break; ··· 1971 1969 switch (p->transmission_mode) { 1972 1970 default: /* Not set, detect it automatically */ 1973 1971 operationMode |= SC_RA_RAM_OP_AUTO_MODE__M; 1974 - /* fall through , try first guess DRX_FFTMODE_8K */ 1972 + /* try first guess DRX_FFTMODE_8K */ 1973 + /* fall through */ 1975 1974 case TRANSMISSION_MODE_8K: 1976 1975 transmissionParams |= SC_RA_RAM_OP_PARAM_MODE_8K; 1977 1976 if (state->type_A) { ··· 2146 2143 switch (p->modulation) { 2147 2144 default: 2148 2145 operationMode |= SC_RA_RAM_OP_AUTO_CONST__M; 2149 - /* fall through , try first guess 2150 - DRX_CONSTELLATION_QAM64 */ 2146 + /* try first guess DRX_CONSTELLATION_QAM64 */ 2147 + /* fall through */ 2151 2148 case QAM_64: 2152 2149 transmissionParams |= SC_RA_RAM_OP_PARAM_CONST_QAM64; 2153 2150 if (state->type_A) { ··· 2283 2280 break; 2284 2281 default: 2285 2282 operationMode |= SC_RA_RAM_OP_AUTO_RATE__M; 2283 + /* fall through */ 2286 2284 case FEC_2_3: 2287 2285 transmissionParams |= SC_RA_RAM_OP_PARAM_RATE_2_3; 2288 2286 if (state->type_A) {
+13 -7
drivers/media/dvb-frontends/drxk_hard.c
··· 3271 3271 case OFDM_SC_RA_RAM_CMD_PROGRAM_PARAM: 3272 3272 status |= write16(state, OFDM_SC_RA_RAM_PARAM1__A, param1); 3273 3273 /* All commands using 1 parameters */ 3274 + /* fall through */ 3274 3275 case OFDM_SC_RA_RAM_CMD_SET_ECHO_TIMING: 3275 3276 case OFDM_SC_RA_RAM_CMD_USER_IO: 3276 3277 status |= write16(state, OFDM_SC_RA_RAM_PARAM0__A, param0); 3277 3278 /* All commands using 0 parameters */ 3279 + /* fall through */ 3278 3280 case OFDM_SC_RA_RAM_CMD_GET_OP_PARAM: 3279 3281 case OFDM_SC_RA_RAM_CMD_NULL: 3280 3282 /* Write command */ ··· 3784 3782 case TRANSMISSION_MODE_AUTO: 3785 3783 default: 3786 3784 operation_mode |= OFDM_SC_RA_RAM_OP_AUTO_MODE__M; 3787 - /* fall through , try first guess DRX_FFTMODE_8K */ 3785 + /* try first guess DRX_FFTMODE_8K */ 3786 + /* fall through */ 3788 3787 case TRANSMISSION_MODE_8K: 3789 3788 transmission_params |= OFDM_SC_RA_RAM_OP_PARAM_MODE_8K; 3790 3789 break; ··· 3799 3796 default: 3800 3797 case GUARD_INTERVAL_AUTO: 3801 3798 operation_mode |= OFDM_SC_RA_RAM_OP_AUTO_GUARD__M; 3802 - /* fall through , try first guess DRX_GUARD_1DIV4 */ 3799 + /* try first guess DRX_GUARD_1DIV4 */ 3800 + /* fall through */ 3803 3801 case GUARD_INTERVAL_1_4: 3804 3802 transmission_params |= OFDM_SC_RA_RAM_OP_PARAM_GUARD_4; 3805 3803 break; ··· 3821 3817 case HIERARCHY_NONE: 3822 3818 default: 3823 3819 operation_mode |= OFDM_SC_RA_RAM_OP_AUTO_HIER__M; 3824 - /* fall through , try first guess SC_RA_RAM_OP_PARAM_HIER_NO */ 3820 + /* try first guess SC_RA_RAM_OP_PARAM_HIER_NO */ 3825 3821 /* transmission_params |= OFDM_SC_RA_RAM_OP_PARAM_HIER_NO; */ 3826 - /* break; */ 3822 + /* fall through */ 3827 3823 case HIERARCHY_1: 3828 3824 transmission_params |= OFDM_SC_RA_RAM_OP_PARAM_HIER_A1; 3829 3825 break; ··· 3841 3837 case QAM_AUTO: 3842 3838 default: 3843 3839 operation_mode |= OFDM_SC_RA_RAM_OP_AUTO_CONST__M; 3844 - /* fall through , try first guess DRX_CONSTELLATION_QAM64 */ 3840 + /* try first guess DRX_CONSTELLATION_QAM64 */ 3841 + /* fall through */ 3845 3842 case QAM_64: 3846 3843 transmission_params |= OFDM_SC_RA_RAM_OP_PARAM_CONST_QAM64; 3847 3844 break; ··· 3885 3880 case FEC_AUTO: 3886 3881 default: 3887 3882 operation_mode |= OFDM_SC_RA_RAM_OP_AUTO_RATE__M; 3888 - /* fall through , try first guess DRX_CODERATE_2DIV3 */ 3883 + /* try first guess DRX_CODERATE_2DIV3 */ 3884 + /* fall through */ 3889 3885 case FEC_2_3: 3890 3886 transmission_params |= OFDM_SC_RA_RAM_OP_PARAM_RATE_2_3; 3891 3887 break; ··· 3920 3914 switch (state->props.bandwidth_hz) { 3921 3915 case 0: 3922 3916 state->props.bandwidth_hz = 8000000; 3923 - /* fall though */ 3917 + /* fall through */ 3924 3918 case 8000000: 3925 3919 bandwidth = DRXK_BANDWIDTH_8MHZ_IN_HZ; 3926 3920 status = write16(state, OFDM_SC_RA_RAM_SRMM_FIX_FACT_8K__A,
+1
drivers/media/dvb-frontends/mt352.c
··· 211 211 if (op->hierarchy == HIERARCHY_AUTO || 212 212 op->hierarchy == HIERARCHY_NONE) 213 213 break; 214 + /* fall through */ 214 215 default: 215 216 return -EINVAL; 216 217 }
+2 -2
drivers/media/dvb-frontends/or51132.c
··· 493 493 switch (reg&0xff) { 494 494 case 0x06: 495 495 if (reg & 0x1000) usK = 3 << 24; 496 - /* Fall through to QAM64 case */ 497 - case 0x43: 496 + /* fall through */ 497 + case 0x43: /* QAM64 */ 498 498 c = 150204167; 499 499 break; 500 500 case 0x45:
+2 -2
drivers/media/dvb-frontends/s5h1411.c
··· 51 51 #define dprintk(arg...) do { \ 52 52 if (debug) \ 53 53 printk(arg); \ 54 - } while (0) 54 + } while (0) 55 55 56 56 /* Register values to initialise the demod, defaults to VSB */ 57 57 static struct init_tab { ··· 410 410 default: 411 411 dprintk("%s(%d KHz) Invalid, defaulting to 5380\n", 412 412 __func__, KHz); 413 - /* no break, need to continue */ 413 + /* fall through */ 414 414 case 5380: 415 415 case 44000: 416 416 s5h1411_writereg(state, S5H1411_I2C_TOP_ADDR, 0x38, 0x1be4);
+2 -1
drivers/media/dvb-frontends/zl10353.c
··· 211 211 break; 212 212 default: 213 213 c->bandwidth_hz = 8000000; 214 - /* fall though */ 214 + /* fall through */ 215 215 case 8000000: 216 216 zl10353_single_write(fe, MCLK_RATIO, 0x75); 217 217 zl10353_single_write(fe, 0x64, 0x36); ··· 268 268 if (c->hierarchy == HIERARCHY_AUTO || 269 269 c->hierarchy == HIERARCHY_NONE) 270 270 break; 271 + /* fall through */ 271 272 default: 272 273 return -EINVAL; 273 274 }
+1
drivers/media/i2c/msp3400-kthreads.c
··· 655 655 break; 656 656 case 0: /* 4.5 */ 657 657 state->detected_std = V4L2_STD_MN; 658 + /* fall-through */ 658 659 default: 659 660 no_second: 660 661 state->second = msp3400c_carrier_detect_main[max1].cdo;
+2
drivers/media/i2c/soc_camera/ov6650.c
··· 709 709 switch (mf->code) { 710 710 case MEDIA_BUS_FMT_Y10_1X10: 711 711 mf->code = MEDIA_BUS_FMT_Y8_1X8; 712 + /* fall through */ 712 713 case MEDIA_BUS_FMT_Y8_1X8: 713 714 case MEDIA_BUS_FMT_YVYU8_2X8: 714 715 case MEDIA_BUS_FMT_YUYV8_2X8: ··· 719 718 break; 720 719 default: 721 720 mf->code = MEDIA_BUS_FMT_SBGGR8_1X8; 721 + /* fall through */ 722 722 case MEDIA_BUS_FMT_SBGGR8_1X8: 723 723 mf->colorspace = V4L2_COLORSPACE_SRGB; 724 724 break;
+2 -1
drivers/media/pci/cx23885/cx23885-cards.c
··· 2081 2081 ts2->gen_ctrl_val = 0xc; /* Serial bus + punctured clock */ 2082 2082 ts2->ts_clk_en_val = 0x1; /* Enable TS_CLK */ 2083 2083 ts2->src_sel_val = CX23885_SRC_SEL_PARALLEL_MPEG_VIDEO; 2084 - /* break omitted intentionally */ 2084 + /* fall-through */ 2085 2085 case CX23885_BOARD_DVICO_FUSIONHDTV_5_EXP: 2086 2086 ts1->gen_ctrl_val = 0xc; /* Serial bus + punctured clock */ 2087 2087 ts1->ts_clk_en_val = 0x1; /* Enable TS_CLK */ ··· 2238 2238 /* Currently only enabled for the integrated IR controller */ 2239 2239 if (!enable_885_ir) 2240 2240 break; 2241 + /* fall-through */ 2241 2242 case CX23885_BOARD_HAUPPAUGE_HVR1250: 2242 2243 case CX23885_BOARD_HAUPPAUGE_HVR1800: 2243 2244 case CX23885_BOARD_HAUPPAUGE_IMPACTVCBE:
+1 -1
drivers/media/pci/cx88/cx88-video.c
··· 1420 1420 request_module("rtc-isl1208"); 1421 1421 core->i2c_rtc = i2c_new_device(&core->i2c_adap, &rtc_info); 1422 1422 } 1423 - /* break intentionally omitted */ 1423 + /* fall-through */ 1424 1424 case CX88_BOARD_DVICO_FUSIONHDTV_5_PCI_NANO: 1425 1425 request_module("ir-kbd-i2c"); 1426 1426 }
+4 -3
drivers/media/pci/ddbridge/ddbridge-core.c
··· 789 789 dvb_frontend_detach(input->fe); 790 790 input->fe = NULL; 791 791 } 792 + /* fall-through */ 792 793 case 4: 793 794 dvb_net_release(&input->dvbnet); 794 - 795 + /* fall-through */ 795 796 case 3: 796 797 dvbdemux->dmx.close(&dvbdemux->dmx); 797 798 dvbdemux->dmx.remove_frontend(&dvbdemux->dmx, ··· 800 799 dvbdemux->dmx.remove_frontend(&dvbdemux->dmx, 801 800 &input->mem_frontend); 802 801 dvb_dmxdev_release(&input->dmxdev); 803 - 802 + /* fall-through */ 804 803 case 2: 805 804 dvb_dmx_release(&input->demux); 806 - 805 + /* fall-through */ 807 806 case 1: 808 807 dvb_unregister_adapter(adap); 809 808 }
+2 -2
drivers/media/pci/saa7134/saa7134-cards.c
··· 7806 7806 dev->name, saa7134_boards[dev->board].name); 7807 7807 break; 7808 7808 } 7809 - /* break intentionally omitted */ 7809 + /* fall-through */ 7810 7810 case SAA7134_BOARD_VIDEOMATE_DVBT_300: 7811 7811 case SAA7134_BOARD_ASUS_EUROPA2_HYBRID: 7812 7812 case SAA7134_BOARD_ASUS_EUROPA_HYBRID: ··· 7864 7864 break; 7865 7865 case SAA7134_BOARD_HAUPPAUGE_HVR1110: 7866 7866 hauppauge_eeprom(dev, dev->eedata+0x80); 7867 - /* break intentionally omitted */ 7867 + /* fall-through */ 7868 7868 case SAA7134_BOARD_PINNACLE_PCTV_310i: 7869 7869 case SAA7134_BOARD_KWORLD_DVBT_210: 7870 7870 case SAA7134_BOARD_TEVION_DVBT_220RF:
+1
drivers/media/pci/solo6x10/solo6x10-core.c
··· 511 511 default: 512 512 dev_warn(&pdev->dev, "Invalid chip_id 0x%02x, assuming 4 ch\n", 513 513 chip_id); 514 + /* fall through */ 514 515 case 5: 515 516 solo_dev->nr_chans = 4; 516 517 solo_dev->nr_ext = 1;
+1
drivers/media/pci/solo6x10/solo6x10-i2c.c
··· 192 192 } 193 193 194 194 solo_dev->i2c_state = IIC_STATE_WRITE; 195 + /* fall through */ 195 196 case IIC_STATE_WRITE: 196 197 ret = solo_i2c_handle_write(solo_dev); 197 198 break;
+3
drivers/media/platform/exynos4-is/fimc-capture.c
··· 1277 1277 case V4L2_SEL_TGT_COMPOSE_DEFAULT: 1278 1278 case V4L2_SEL_TGT_COMPOSE_BOUNDS: 1279 1279 f = &ctx->d_frame; 1280 + /* fall through */ 1280 1281 case V4L2_SEL_TGT_CROP_BOUNDS: 1281 1282 case V4L2_SEL_TGT_CROP_DEFAULT: 1282 1283 s->r.left = 0; ··· 1288 1287 1289 1288 case V4L2_SEL_TGT_COMPOSE: 1290 1289 f = &ctx->d_frame; 1290 + /* fall through */ 1291 1291 case V4L2_SEL_TGT_CROP: 1292 1292 s->r.left = f->offs_h; 1293 1293 s->r.top = f->offs_v; ··· 1612 1610 switch (sel->target) { 1613 1611 case V4L2_SEL_TGT_COMPOSE_BOUNDS: 1614 1612 f = &ctx->d_frame; 1613 + /* fall through */ 1615 1614 case V4L2_SEL_TGT_CROP_BOUNDS: 1616 1615 r->width = f->o_width; 1617 1616 r->height = f->o_height;
+1
drivers/media/platform/marvell-ccic/mcam-core.c
··· 393 393 dma_free_coherent(cam->dev, cam->dma_buf_size, 394 394 cam->dma_bufs[0], cam->dma_handles[0]); 395 395 cam->nbufs = 0; 396 + /* fall-through */ 396 397 case 0: 397 398 cam_err(cam, "Insufficient DMA buffers, cannot operate\n"); 398 399 return -ENOMEM;
+1
drivers/media/platform/pxa_camera.c
··· 1291 1291 * transformation. Note that UYVY is the only format that 1292 1292 * should be used if pxa framebuffer Overlay2 is used. 1293 1293 */ 1294 + /* fall through */ 1294 1295 case V4L2_PIX_FMT_UYVY: 1295 1296 case V4L2_PIX_FMT_VYUY: 1296 1297 case V4L2_PIX_FMT_YUYV:
+2
drivers/media/platform/sh_vou.c
··· 229 229 break; 230 230 case V4L2_PIX_FMT_RGB565: 231 231 dataswap ^= 1; 232 + /* fall through */ 232 233 case V4L2_PIX_FMT_RGB565X: 233 234 row_coeff = 2; 234 235 break; ··· 816 815 default: 817 816 pr_warn("%s(): Invalid bus-format code %d, using default 8-bit\n", 818 817 __func__, bus_fmt); 818 + /* fall through */ 819 819 case SH_VOU_BUS_8BIT: 820 820 return 1; 821 821 case SH_VOU_BUS_16BIT:
+1
drivers/media/rc/iguanair.c
··· 113 113 break; 114 114 case CMD_TX_OVERFLOW: 115 115 ir->tx_overflow = true; 116 + /* fall through */ 116 117 case CMD_RECEIVER_OFF: 117 118 case CMD_RECEIVER_ON: 118 119 case CMD_SEND:
+1 -1
drivers/media/tuners/tda18271-fe.c
··· 960 960 break; 961 961 case SYS_DVBC_ANNEX_B: 962 962 bw = 6000000; 963 - /* falltrough */ 963 + /* fall through */ 964 964 case SYS_DVBC_ANNEX_A: 965 965 case SYS_DVBC_ANNEX_C: 966 966 if (bw <= 6000000) {
+1
drivers/media/tuners/xc5000.c
··· 788 788 if (!bw) 789 789 bw = 6000000; 790 790 /* fall to OFDM handling */ 791 + /* fall through */ 791 792 case SYS_DMBTH: 792 793 case SYS_DVBT: 793 794 case SYS_DVBT2:
+34 -17
drivers/media/usb/cpia2/cpia2_core.c
··· 173 173 cmd.start = CPIA2_VP_DEVICEH; 174 174 break; 175 175 case CPIA2_CMD_SET_VP_BRIGHTNESS: 176 - cmd.buffer.block_data[0] = param; /* Then fall through */ 176 + cmd.buffer.block_data[0] = param; 177 + /* fall through */ 177 178 case CPIA2_CMD_GET_VP_BRIGHTNESS: 178 179 cmd.req_mode = CAMERAACCESS_TYPE_BLOCK | CAMERAACCESS_VP; 179 180 cmd.reg_count = 1; ··· 184 183 cmd.start = CPIA2_VP5_EXPOSURE_TARGET; 185 184 break; 186 185 case CPIA2_CMD_SET_CONTRAST: 187 - cmd.buffer.block_data[0] = param; /* Then fall through */ 186 + cmd.buffer.block_data[0] = param; 187 + /* fall through */ 188 188 case CPIA2_CMD_GET_CONTRAST: 189 189 cmd.req_mode = CAMERAACCESS_TYPE_BLOCK | CAMERAACCESS_VP; 190 190 cmd.reg_count = 1; 191 191 cmd.start = CPIA2_VP_YRANGE; 192 192 break; 193 193 case CPIA2_CMD_SET_VP_SATURATION: 194 - cmd.buffer.block_data[0] = param; /* Then fall through */ 194 + cmd.buffer.block_data[0] = param; 195 + /* fall through */ 195 196 case CPIA2_CMD_GET_VP_SATURATION: 196 197 cmd.req_mode = CAMERAACCESS_TYPE_BLOCK | CAMERAACCESS_VP; 197 198 cmd.reg_count = 1; ··· 203 200 cmd.start = CPIA2_VP5_MCUVSATURATION; 204 201 break; 205 202 case CPIA2_CMD_SET_VP_GPIO_DATA: 206 - cmd.buffer.block_data[0] = param; /* Then fall through */ 203 + cmd.buffer.block_data[0] = param; 204 + /* fall through */ 207 205 case CPIA2_CMD_GET_VP_GPIO_DATA: 208 206 cmd.req_mode = CAMERAACCESS_TYPE_BLOCK | CAMERAACCESS_VP; 209 207 cmd.reg_count = 1; 210 208 cmd.start = CPIA2_VP_GPIO_DATA; 211 209 break; 212 210 case CPIA2_CMD_SET_VP_GPIO_DIRECTION: 213 - cmd.buffer.block_data[0] = param; /* Then fall through */ 211 + cmd.buffer.block_data[0] = param; 212 + /* fall through */ 214 213 case CPIA2_CMD_GET_VP_GPIO_DIRECTION: 215 214 cmd.req_mode = CAMERAACCESS_TYPE_BLOCK | CAMERAACCESS_VP; 216 215 cmd.reg_count = 1; 217 216 cmd.start = CPIA2_VP_GPIO_DIRECTION; 218 217 break; 219 218 case CPIA2_CMD_SET_VC_MP_GPIO_DATA: 220 - cmd.buffer.block_data[0] = param; /* Then fall through */ 219 + cmd.buffer.block_data[0] = param; 220 + /* fall through */ 221 221 case CPIA2_CMD_GET_VC_MP_GPIO_DATA: 222 222 cmd.req_mode = CAMERAACCESS_TYPE_BLOCK | CAMERAACCESS_VC; 223 223 cmd.reg_count = 1; 224 224 cmd.start = CPIA2_VC_MP_DATA; 225 225 break; 226 226 case CPIA2_CMD_SET_VC_MP_GPIO_DIRECTION: 227 - cmd.buffer.block_data[0] = param; /* Then fall through */ 227 + cmd.buffer.block_data[0] = param; 228 + /*fall through */ 228 229 case CPIA2_CMD_GET_VC_MP_GPIO_DIRECTION: 229 230 cmd.req_mode = CAMERAACCESS_TYPE_BLOCK | CAMERAACCESS_VC; 230 231 cmd.reg_count = 1; ··· 242 235 cmd.buffer.block_data[0] = param; 243 236 break; 244 237 case CPIA2_CMD_SET_FLICKER_MODES: 245 - cmd.buffer.block_data[0] = param; /* Then fall through */ 238 + cmd.buffer.block_data[0] = param; 239 + /* fall through */ 246 240 case CPIA2_CMD_GET_FLICKER_MODES: 247 241 cmd.req_mode = CAMERAACCESS_TYPE_BLOCK | CAMERAACCESS_VP; 248 242 cmd.reg_count = 1; ··· 288 280 cmd.start = CPIA2_SYSTEM_SYSTEM_CONTROL; 289 281 cmd.buffer.block_data[0] = CPIA2_SYSTEM_CONTROL_CLEAR_ERR; 290 282 break; 291 - case CPIA2_CMD_SET_USER_MODE: /* Then fall through */ 283 + case CPIA2_CMD_SET_USER_MODE: 292 284 cmd.buffer.block_data[0] = param; 285 + /* fall through */ 293 286 case CPIA2_CMD_GET_USER_MODE: 294 287 cmd.req_mode = CAMERAACCESS_TYPE_BLOCK | CAMERAACCESS_VP; 295 288 cmd.reg_count = 1; ··· 309 300 cmd.buffer.block_data[0] = param; 310 301 break; 311 302 case CPIA2_CMD_SET_WAKEUP: 312 - cmd.buffer.block_data[0] = param; /* Then fall through */ 303 + cmd.buffer.block_data[0] = param; 304 + /* fall through */ 313 305 case CPIA2_CMD_GET_WAKEUP: 314 306 cmd.req_mode = CAMERAACCESS_TYPE_BLOCK | CAMERAACCESS_VC; 315 307 cmd.reg_count = 1; 316 308 cmd.start = CPIA2_VC_WAKEUP; 317 309 break; 318 310 case CPIA2_CMD_SET_PW_CONTROL: 319 - cmd.buffer.block_data[0] = param; /* Then fall through */ 311 + cmd.buffer.block_data[0] = param; 312 + /* fall through */ 320 313 case CPIA2_CMD_GET_PW_CONTROL: 321 314 cmd.req_mode = CAMERAACCESS_TYPE_BLOCK | CAMERAACCESS_VC; 322 315 cmd.reg_count = 1; ··· 330 319 cmd.start = CPIA2_VP_SYSTEMSTATE; 331 320 break; 332 321 case CPIA2_CMD_SET_SYSTEM_CTRL: 333 - cmd.buffer.block_data[0] = param; /* Then fall through */ 322 + cmd.buffer.block_data[0] = param; 323 + /* fall through */ 334 324 case CPIA2_CMD_GET_SYSTEM_CTRL: 335 325 cmd.req_mode = 336 326 CAMERAACCESS_TYPE_BLOCK | CAMERAACCESS_SYSTEM; ··· 339 327 cmd.start = CPIA2_SYSTEM_SYSTEM_CONTROL; 340 328 break; 341 329 case CPIA2_CMD_SET_VP_SYSTEM_CTRL: 342 - cmd.buffer.block_data[0] = param; /* Then fall through */ 330 + cmd.buffer.block_data[0] = param; 331 + /* fall through */ 343 332 case CPIA2_CMD_GET_VP_SYSTEM_CTRL: 344 333 cmd.req_mode = CAMERAACCESS_TYPE_BLOCK | CAMERAACCESS_VP; 345 334 cmd.reg_count = 1; 346 335 cmd.start = CPIA2_VP_SYSTEMCTRL; 347 336 break; 348 337 case CPIA2_CMD_SET_VP_EXP_MODES: 349 - cmd.buffer.block_data[0] = param; /* Then fall through */ 338 + cmd.buffer.block_data[0] = param; 339 + /* fall through */ 350 340 case CPIA2_CMD_GET_VP_EXP_MODES: 351 341 cmd.req_mode = CAMERAACCESS_TYPE_BLOCK | CAMERAACCESS_VP; 352 342 cmd.reg_count = 1; 353 343 cmd.start = CPIA2_VP_EXPOSURE_MODES; 354 344 break; 355 345 case CPIA2_CMD_SET_DEVICE_CONFIG: 356 - cmd.buffer.block_data[0] = param; /* Then fall through */ 346 + cmd.buffer.block_data[0] = param; 347 + /* fall through */ 357 348 case CPIA2_CMD_GET_DEVICE_CONFIG: 358 349 cmd.req_mode = CAMERAACCESS_TYPE_BLOCK | CAMERAACCESS_VP; 359 350 cmd.reg_count = 1; ··· 376 361 cmd.start = CPIA2_SENSOR_CR1; 377 362 break; 378 363 case CPIA2_CMD_SET_VC_CONTROL: 379 - cmd.buffer.block_data[0] = param; /* Then fall through */ 364 + cmd.buffer.block_data[0] = param; 365 + /* fall through */ 380 366 case CPIA2_CMD_GET_VC_CONTROL: 381 367 cmd.req_mode = CAMERAACCESS_TYPE_BLOCK | CAMERAACCESS_VC; 382 368 cmd.reg_count = 1; ··· 411 395 case CPIA2_CMD_SET_USER_EFFECTS: /* Note: Be careful with this as 412 396 this register can also affect 413 397 flicker modes */ 414 - cmd.buffer.block_data[0] = param; /* Then fall through */ 398 + cmd.buffer.block_data[0] = param; 399 + /* fall through */ 415 400 case CPIA2_CMD_GET_USER_EFFECTS: 416 401 cmd.req_mode = CAMERAACCESS_TYPE_BLOCK | CAMERAACCESS_VP; 417 402 cmd.reg_count = 1;
+1 -1
drivers/media/usb/cx231xx/cx231xx-video.c
··· 1134 1134 /* The DVB core will handle it */ 1135 1135 if (dev->tuner_type == TUNER_ABSENT) 1136 1136 continue; 1137 - /* fall though */ 1137 + /* fall through */ 1138 1138 default: /* just to shut up a gcc warning */ 1139 1139 ent->function = MEDIA_ENT_F_CONN_RF; 1140 1140 break;
+1
drivers/media/usb/dvb-usb-v2/af9015.c
··· 52 52 case READ_I2C: 53 53 write = 0; 54 54 state->buf[2] |= 0x01; /* set I2C direction */ 55 + /* fall through */ 55 56 case WRITE_I2C: 56 57 state->buf[0] = READ_WRITE_I2C; 57 58 break;
+1
drivers/media/usb/dvb-usb-v2/lmedm04.c
··· 1065 1065 } 1066 1066 break; 1067 1067 } 1068 + /* fall through */ 1068 1069 case 0x22f0: 1069 1070 st->i2c_gate = 5; 1070 1071 adap->fe[0] = dvb_attach(m88rs2000_attach,
+1
drivers/media/usb/dvb-usb/dib0700_devices.c
··· 1659 1659 switch (band) { 1660 1660 default: 1661 1661 deb_info("Warning : Rf frequency (%iHz) is not in the supported range, using VHF switch ", fe->dtv_property_cache.frequency); 1662 + /* fall through */ 1662 1663 case BAND_VHF: 1663 1664 state->dib8000_ops.set_gpio(fe, 3, 0, 1); 1664 1665 break;
+3 -1
drivers/media/usb/dvb-usb/dw2102.c
··· 1840 1840 switch (le16_to_cpu(dev->descriptor.idProduct)) { 1841 1841 case USB_PID_TEVII_S650: 1842 1842 dw2104_properties.rc.core.rc_codes = RC_MAP_TEVII_NEC; 1843 + /* fall through */ 1843 1844 case USB_PID_DW2104: 1844 1845 reset = 1; 1845 1846 dw210x_op_rw(dev, 0xc4, 0x0000, 0, &reset, 1, 1846 1847 DW210X_WRITE_MSG); 1847 - /* break omitted intentionally */ 1848 + /* fall through */ 1848 1849 case USB_PID_DW3101: 1849 1850 reset = 0; 1850 1851 dw210x_op_rw(dev, 0xbf, 0x0040, 0, &reset, 0, ··· 1878 1877 break; 1879 1878 } 1880 1879 } 1880 + /* fall through */ 1881 1881 case 0x2101: 1882 1882 dw210x_op_rw(dev, 0xbc, 0x0030, 0, &reset16[0], 2, 1883 1883 DW210X_READ_MSG);
+2 -1
drivers/media/usb/gspca/ov519.c
··· 3526 3526 sd->clockdiv = 0; 3527 3527 break; 3528 3528 } 3529 - /* Fall through for 640x480 case */ 3529 + /* For 640x480 case */ 3530 + /* fall through */ 3530 3531 default: 3531 3532 /* case 20: */ 3532 3533 /* case 15: */
+2 -1
drivers/media/usb/pwc/pwc-v4l.c
··· 568 568 pdev->gain_valid = true; 569 569 if (!DEVICE_USE_CODEC3(pdev->type)) 570 570 break; 571 - /* Fall through for CODEC3 where autogain also controls expo */ 571 + /* For CODEC3 where autogain also controls expo */ 572 + /* fall through */ 572 573 case V4L2_CID_EXPOSURE_AUTO: 573 574 if (pdev->exposure_valid && time_before(jiffies, 574 575 pdev->last_exposure_update + HZ / 4)) {
+3
drivers/media/usb/usbvision/usbvision-i2c.c
··· 311 311 switch (len) { 312 312 case 4: 313 313 buf[3] = usbvision_read_reg(usbvision, USBVISION_SER_DAT4); 314 + /* fall through */ 314 315 case 3: 315 316 buf[2] = usbvision_read_reg(usbvision, USBVISION_SER_DAT3); 317 + /* fall through */ 316 318 case 2: 317 319 buf[1] = usbvision_read_reg(usbvision, USBVISION_SER_DAT2); 320 + /* fall through */ 318 321 case 1: 319 322 buf[0] = usbvision_read_reg(usbvision, USBVISION_SER_DAT1); 320 323 break;
+1 -1
drivers/media/usb/uvc/uvc_video.c
··· 1327 1327 case -ENOENT: /* usb_kill_urb() called. */ 1328 1328 if (stream->frozen) 1329 1329 return; 1330 - 1330 + /* fall through */ 1331 1331 case -ECONNRESET: /* usb_unlink_urb() called. */ 1332 1332 case -ESHUTDOWN: /* The endpoint is being disabled. */ 1333 1333 uvc_queue_cancel(queue, urb->status == -ESHUTDOWN);