Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

usb: chipidea: Add errata for revision 2.40a

At chipidea revision 2.40a, there is a below errata:

9000531823 B2-Medium Adding a dTD to a Primed Endpoint May Not Get Recognized

Title: Adding a dTD to a Primed Endpoint May Not Get Recognized

Impacted Configuration: All device mode configurations.

Description:
There is an issue with the add dTD tripwire semaphore (ATDTW bit in USBCMD register)
that can cause the controller to ignore a dTD that is added to a primed endpoint.
When this happens, the software can read the tripwire bit and the status bit at '1'
even though the endpoint is unprimed.

After executing a dTD, the device controller endpoint state machine executes a final
read of the dTD terminate bit to check if the application added a dTD to the linked
list at the last moment. This read is done in the finpkt_read_latest_next_td (44) state.
After the read is performed, if the terminate bit is still set, the state machine moves
to unprime the endpoint. The decision to unprime the endpoint is done in the
checkqh_decision (59) state, based on the value of the terminate bit.
Before reaching the checkqh_decision state, the state machine traverses the
writeqhtd_status (57), writeqh_status (56), and release_prime_mask (42) states.
As shown in the waveform, the ep_addtd_tripwire_clr signal is not set to clear
the tripwire bit in these states.

Workaround:
The software must implement a periodic poll cycle, and check for each dTD
pending on execution (Active = 1), if the enpoint is primed. It can do this by reading
the corresponding bits in the ENDPTPRIME and ENDPTSTAT registers. If these bits are
read at 0, the software needs to re-prime the endpoint by writing 1 to the corresponding
bit in the ENDPTPRIME register. This can be done for every microframe, every frame or
with a larger interval, depending on the urgency of transfer execution for the application.

Tested-by: Stefan Agner <stefan@agner.ch>
Signed-off-by: Peter Chen <peter.chen@freescale.com>
Signed-off-by: Sanchayan Maity <maitysanchayan@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

authored by

Sanchayan Maity and committed by
Greg Kroah-Hartman
06bdfcdb cb271f3c

+20
+20
drivers/usb/chipidea/udc.c
··· 522 522 kfree(pending); 523 523 } 524 524 525 + static int reprime_dtd(struct ci_hdrc *ci, struct ci_hw_ep *hwep, 526 + struct td_node *node) 527 + { 528 + hwep->qh.ptr->td.next = node->dma; 529 + hwep->qh.ptr->td.token &= 530 + cpu_to_le32(~(TD_STATUS_HALTED | TD_STATUS_ACTIVE)); 531 + 532 + /* Synchronize before ep prime */ 533 + wmb(); 534 + 535 + return hw_ep_prime(ci, hwep->num, hwep->dir, 536 + hwep->type == USB_ENDPOINT_XFER_CONTROL); 537 + } 538 + 525 539 /** 526 540 * _hardware_dequeue: handles a request at hardware level 527 541 * @gadget: gadget ··· 549 535 struct td_node *node, *tmpnode; 550 536 unsigned remaining_length; 551 537 unsigned actual = hwreq->req.length; 538 + struct ci_hdrc *ci = hwep->ci; 552 539 553 540 if (hwreq->req.status != -EALREADY) 554 541 return -EINVAL; ··· 559 544 list_for_each_entry_safe(node, tmpnode, &hwreq->tds, td) { 560 545 tmptoken = le32_to_cpu(node->ptr->token); 561 546 if ((TD_STATUS_ACTIVE & tmptoken) != 0) { 547 + int n = hw_ep_bit(hwep->num, hwep->dir); 548 + 549 + if (ci->rev == CI_REVISION_24) 550 + if (!hw_read(ci, OP_ENDPTSTAT, BIT(n))) 551 + reprime_dtd(ci, hwep, node); 562 552 hwreq->req.status = -EALREADY; 563 553 return -EBUSY; 564 554 }