Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

dt-bindings: pinctrl: mt8186: Fix 'reg-names' for pinctrl nodes

The mt8186 contains 8 GPIO physical address bases that correspond to
the 'reg-names' of the pinctrl driver. The 'reg-names' entries in
bindings are ordered incorrectly, though. The system crashes due of an
erroneous address when the regulator initializes.

We fix the 'reg-names' for the pinctrl nodes and the pinctrl-mt8186
example in bindings.

Fixes: 338e953f1bd1 ("dt-bindings: pinctrl: mt8186: add pinctrl file and binding document")
Co-developed-by: Guodong Liu <guodong.liu@mediatek.com>
Signed-off-by: Guodong Liu <guodong.liu@mediatek.com>
Signed-off-by: Allen-KH Cheng <allen-kh.cheng@mediatek.com>
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
Link: https://lore.kernel.org/r/20220819120649.21523-1-allen-kh.cheng@mediatek.com
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

authored by

Allen-KH Cheng and committed by
Linus Walleij
0684bc79 11b918d9

+7 -7
+7 -7
Documentation/devicetree/bindings/pinctrl/pinctrl-mt8186.yaml
··· 41 41 Gpio base register names. 42 42 items: 43 43 - const: iocfg0 44 - - const: iocfg_bm 45 - - const: iocfg_bl 46 - - const: iocfg_br 44 + - const: iocfg_lt 47 45 - const: iocfg_lm 46 + - const: iocfg_lb 47 + - const: iocfg_bl 48 48 - const: iocfg_rb 49 - - const: iocfg_tl 49 + - const: iocfg_rt 50 50 - const: eint 51 51 52 52 interrupt-controller: true ··· 235 235 <0x10002A00 0x0200>, 236 236 <0x10002c00 0x0200>, 237 237 <0x1000b000 0x1000>; 238 - reg-names = "iocfg0", "iocfg_bm", "iocfg_bl", 239 - "iocfg_br", "iocfg_lm", "iocfg_rb", 240 - "iocfg_tl", "eint"; 238 + reg-names = "iocfg0", "iocfg_lt", "iocfg_lm", 239 + "iocfg_lb", "iocfg_bl", "iocfg_rb", 240 + "iocfg_rt", "eint"; 241 241 gpio-controller; 242 242 #gpio-cells = <2>; 243 243 gpio-ranges = <&pio 0 0 185>;