Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

leds: ledtrig-ide-disk: Make the driver explicitly non-modular

The Kconfig for this driver is currently:

config LEDS_TRIGGER_IDE_DISK
bool "LED IDE Disk Trigger"

...meaning that it currently is not being built as a module by anyone.
Lets remove the modular code that is essentially orphaned, so that
when reading the driver there is no doubt it is builtin-only.

Since module_init translates to device_initcall in the non-modular
case, the init ordering remains unchanged with this commit.

We also delete the MODULE_LICENSE tag etc. since all that information
is already contained at the top of the file in the comments.

Cc: Bryan Wu <cooloney@gmail.com>
Cc: Richard Purdie <rpurdie@rpsys.net>
Cc: linux-leds@vger.kernel.org
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
Signed-off-by: Jacek Anaszewski <j.anaszewski@samsung.com>

authored by

Paul Gortmaker and committed by
Jacek Anaszewski
067a8f3c 227a0ca1

+1 -13
+1 -13
drivers/leds/trigger/ledtrig-ide-disk.c
··· 11 11 * 12 12 */ 13 13 14 - #include <linux/module.h> 15 14 #include <linux/kernel.h> 16 15 #include <linux/init.h> 17 16 #include <linux/leds.h> ··· 32 33 led_trigger_register_simple("ide-disk", &ledtrig_ide); 33 34 return 0; 34 35 } 35 - 36 - static void __exit ledtrig_ide_exit(void) 37 - { 38 - led_trigger_unregister_simple(ledtrig_ide); 39 - } 40 - 41 - module_init(ledtrig_ide_init); 42 - module_exit(ledtrig_ide_exit); 43 - 44 - MODULE_AUTHOR("Richard Purdie <rpurdie@openedhand.com>"); 45 - MODULE_DESCRIPTION("LED IDE Disk Activity Trigger"); 46 - MODULE_LICENSE("GPL"); 36 + device_initcall(ledtrig_ide_init);