Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

ASoC: codecs: lpass-macro: Use enum for handling codec version

Replace 'int' with proper 'enum lpass_codec_version' in every place
which handles the parsed codec version (not raw register values!) to be
explicit about contents of the variable. This makes code easier to read
and compilers could check missing switch cases.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Link: https://patch.msgid.link/20240625165736.722106-2-krzysztof.kozlowski@linaro.org
Signed-off-by: Mark Brown <broonie@kernel.org>

authored by

Krzysztof Kozlowski and committed by
Mark Brown
06462d6f ebc1a540

+7 -7
+4 -4
sound/soc/codecs/lpass-macro-common.c
··· 12 12 #include "lpass-macro-common.h" 13 13 14 14 static DEFINE_MUTEX(lpass_codec_mutex); 15 - static int lpass_codec_version; 15 + static enum lpass_codec_version lpass_codec_version; 16 16 17 17 struct lpass_macro *lpass_macro_pds_init(struct device *dev) 18 18 { ··· 69 69 } 70 70 EXPORT_SYMBOL_GPL(lpass_macro_pds_exit); 71 71 72 - void lpass_macro_set_codec_version(int version) 72 + void lpass_macro_set_codec_version(enum lpass_codec_version version) 73 73 { 74 74 mutex_lock(&lpass_codec_mutex); 75 75 lpass_codec_version = version; ··· 77 77 } 78 78 EXPORT_SYMBOL_GPL(lpass_macro_set_codec_version); 79 79 80 - int lpass_macro_get_codec_version(void) 80 + enum lpass_codec_version lpass_macro_get_codec_version(void) 81 81 { 82 - int ver; 82 + enum lpass_codec_version ver; 83 83 84 84 mutex_lock(&lpass_codec_mutex); 85 85 ver = lpass_codec_version;
+2 -2
sound/soc/codecs/lpass-macro-common.h
··· 38 38 39 39 struct lpass_macro *lpass_macro_pds_init(struct device *dev); 40 40 void lpass_macro_pds_exit(struct lpass_macro *pds); 41 - void lpass_macro_set_codec_version(int version); 42 - int lpass_macro_get_codec_version(void); 41 + void lpass_macro_set_codec_version(enum lpass_codec_version version); 42 + enum lpass_codec_version lpass_macro_get_codec_version(void); 43 43 44 44 static inline const char *lpass_macro_get_codec_version_string(int version) 45 45 {
+1 -1
sound/soc/codecs/lpass-rx-macro.c
··· 642 642 int rx_mclk_users; 643 643 int clsh_users; 644 644 int rx_mclk_cnt; 645 - int codec_version; 645 + enum lpass_codec_version codec_version; 646 646 int rxn_reg_stride; 647 647 bool is_ear_mode_on; 648 648 bool hph_pwr_mode;