Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

net: ravb: Fix -Wmaybe-uninitialized warning

Fix a -Wmaybe-uninitialized warning by initializing the variable to
NULL. The warning is bogus and should not happen, but fixing it allows
running the check on the driver to catch potential future problems.

$ make CFLAGS_ravb_main.o=-Wmaybe-uninitialized

In function 'ravb_rx_csum_gbeth',
inlined from 'ravb_rx_gbeth' at .../linux/drivers/net/ethernet/renesas/ravb_main.c:923:6:
.../linux/drivers/net/ethernet/renesas/ravb_main.c:765:25: error: 'skb' may be used uninitialized [-Werror=maybe-uninitialized]
765 | if (unlikely(skb->len < csum_len))
| ~~~^~~~~
.../linux/include/linux/compiler.h:77:45: note: in definition of macro 'unlikely'
77 | # define unlikely(x) __builtin_expect(!!(x), 0)
| ^
.../linux/drivers/net/ethernet/renesas/ravb_main.c: In function 'ravb_rx_gbeth':
.../linux/drivers/net/ethernet/renesas/ravb_main.c:806:25: note: 'skb' was declared here
806 | struct sk_buff *skb;
| ^~~
cc1: all warnings being treated as errors

Warning was found when cross compiling using aarch64-linux-gnu-gcc (GCC)
15.1.0.

Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
Link: https://patch.msgid.link/20250913133229.2087822-1-niklas.soderlund+renesas@ragnatech.se
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

authored by

Niklas Söderlund and committed by
Jakub Kicinski
05c05d14 56f34e97

+2 -1
+2 -1
drivers/net/ethernet/renesas/ravb_main.c
··· 802 802 const struct ravb_hw_info *info = priv->info; 803 803 struct net_device_stats *stats; 804 804 struct ravb_rx_desc *desc; 805 - struct sk_buff *skb; 806 805 int rx_packets = 0; 807 806 u8 desc_status; 808 807 u16 desc_len; ··· 814 815 stats = &priv->stats[q]; 815 816 816 817 for (i = 0; i < limit; i++, priv->cur_rx[q]++) { 818 + struct sk_buff *skb = NULL; 819 + 817 820 entry = priv->cur_rx[q] % priv->num_rx_ring[q]; 818 821 desc = &priv->rx_ring[q].desc[entry]; 819 822 if (rx_packets == budget || desc->die_dt == DT_FEMPTY)