Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

mfd: tps65910: Fix wrong ack_base register

The interrupt status registers of TPS65910/1 should be cleared
when the associated interrupt event occurs.
This work is done in the regmap irq thread - using 'ack_base' register.
The ACK registers should be fixed as status register, not mask registers.

This patch fixes the infinite interrupt event problem by clearing
interrupt status registers.

Tested on the AM3517 Craneboard.

Signed-off-by: Milo(Woogyom) Kim <milo.kim@ti.com>
Acked-by: Laxman Dewangan <ldewangan@nvidia.com>
Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>

authored by

Kim, Milo and committed by
Samuel Ortiz
0582c0fa 0e5fca81

+2 -2
+2 -2
drivers/mfd/tps65910.c
··· 211 211 .irq_reg_stride = 2, 212 212 .status_base = TPS65910_INT_STS, 213 213 .mask_base = TPS65910_INT_MSK, 214 - .ack_base = TPS65910_INT_MSK, 214 + .ack_base = TPS65910_INT_STS, 215 215 }; 216 216 217 217 static struct regmap_irq_chip tps65910_irq_chip = { ··· 222 222 .irq_reg_stride = 2, 223 223 .status_base = TPS65910_INT_STS, 224 224 .mask_base = TPS65910_INT_MSK, 225 - .ack_base = TPS65910_INT_MSK, 225 + .ack_base = TPS65910_INT_STS, 226 226 }; 227 227 228 228 static int tps65910_irq_init(struct tps65910 *tps65910, int irq,