Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

drm/panel: ltk050h3146w: use dev_err_probe wherever possible

This is only a cosmetic change.

This replaces a hand-crafted EPROBE_DEFER handling for deciding to print
an error message with dev_err_probe.

A side-effect is that dev_err_probe also adds a debug message when it's
not EPROBE_DEFER, but this is seen as an improvement.

Cc: Quentin Schulz <foss+kernel@0leil.net>
Signed-off-by: Quentin Schulz <quentin.schulz@theobroma-systems.com>
Reviewed-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
Link: https://patchwork.freedesktop.org/patch/msgid/20240104-ltk-dev_err_probe-v1-2-8ef3c0b585d8@theobroma-systems.com

authored by

Quentin Schulz and committed by
Heiko Stuebner
056a9965 65afd91e

+5 -12
+5 -12
drivers/gpu/drm/panel/panel-leadtek-ltk050h3146w.c
··· 650 650 return dev_err_probe(dev, PTR_ERR(ctx->reset_gpio), "cannot get reset gpio\n"); 651 651 652 652 ctx->vci = devm_regulator_get(dev, "vci"); 653 - if (IS_ERR(ctx->vci)) { 654 - ret = PTR_ERR(ctx->vci); 655 - if (ret != -EPROBE_DEFER) 656 - dev_err(dev, "Failed to request vci regulator: %d\n", ret); 657 - return ret; 658 - } 653 + if (IS_ERR(ctx->vci)) 654 + return dev_err_probe(dev, PTR_ERR(ctx->vci), "Failed to request vci regulator\n"); 659 655 660 656 ctx->iovcc = devm_regulator_get(dev, "iovcc"); 661 - if (IS_ERR(ctx->iovcc)) { 662 - ret = PTR_ERR(ctx->iovcc); 663 - if (ret != -EPROBE_DEFER) 664 - dev_err(dev, "Failed to request iovcc regulator: %d\n", ret); 665 - return ret; 666 - } 657 + if (IS_ERR(ctx->iovcc)) 658 + return dev_err_probe(dev, PTR_ERR(ctx->iovcc), 659 + "Failed to request iovcc regulator\n"); 667 660 668 661 mipi_dsi_set_drvdata(dsi, ctx); 669 662