Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

power: supply: sc2731_charger: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.
To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new() which already returns void. Eventually after all drivers
are converted, .remove_new() is renamed to .remove().

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20230918133700.1254499-25-u.kleine-koenig@pengutronix.de
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>

authored by

Uwe Kleine-König and committed by
Sebastian Reichel
0569d4cf 9f0da40a

+2 -4
+2 -4
drivers/power/supply/sc2731_charger.c
··· 511 511 return 0; 512 512 } 513 513 514 - static int sc2731_charger_remove(struct platform_device *pdev) 514 + static void sc2731_charger_remove(struct platform_device *pdev) 515 515 { 516 516 struct sc2731_charger_info *info = platform_get_drvdata(pdev); 517 517 518 518 usb_unregister_notifier(info->usb_phy, &info->usb_notify); 519 - 520 - return 0; 521 519 } 522 520 523 521 static const struct of_device_id sc2731_charger_of_match[] = { ··· 530 532 .of_match_table = sc2731_charger_of_match, 531 533 }, 532 534 .probe = sc2731_charger_probe, 533 - .remove = sc2731_charger_remove, 535 + .remove_new = sc2731_charger_remove, 534 536 }; 535 537 536 538 module_platform_driver(sc2731_charger_driver);