Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

ARM: tegra: Don't enable PLLX while resuming from LP1 on Tegra30

PLLX may be kept disabled if cpufreq driver selects some other clock for
CPU. In that case PLLX will be disabled later in the resume path by the
CLK driver, which also can enable PLLX if necessary by itself. Thus there
is no need to enable PLLX early during resume. Tegra114/124 CLK drivers do
not manage PLLX on resume and thus they are left untouched by this patch.

Acked-by: Peter De Schrijver <pdeschrijver@nvidia.com>
Tested-by: Peter Geis <pgwipeout@gmail.com>
Tested-by: Marcel Ziswiler <marcel@ziswiler.com>
Tested-by: Jasper Korten <jja2000@gmail.com>
Tested-by: David Heidelberg <david@ixit.cz>
Tested-by: Nicolas Chauvet <kwizart@gmail.com>
Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
Signed-off-by: Thierry Reding <treding@nvidia.com>

authored by

Dmitry Osipenko and committed by
Thierry Reding
04985d00 d3c32c04

+7 -2
+7 -2
arch/arm/mach-tegra/sleep-tegra30.S
··· 361 361 362 362 pll_enable r1, r0, CLK_RESET_PLLM_BASE, CLK_RESET_PLLM_MISC 363 363 pll_enable r1, r0, CLK_RESET_PLLC_BASE, CLK_RESET_PLLC_MISC 364 - pll_enable r1, r0, CLK_RESET_PLLX_BASE, CLK_RESET_PLLX_MISC 365 364 366 365 _pll_m_c_x_done: 367 366 pll_enable r1, r0, CLK_RESET_PLLP_BASE, CLK_RESET_PLLP_MISC ··· 370 371 pll_locked r1, r0, CLK_RESET_PLLP_BASE 371 372 pll_locked r1, r0, CLK_RESET_PLLA_BASE 372 373 pll_locked r1, r0, CLK_RESET_PLLC_BASE 373 - pll_locked r1, r0, CLK_RESET_PLLX_BASE 374 374 375 + /* 376 + * CPUFreq driver could select other PLL for CPU. PLLX will be 377 + * enabled by the Tegra30 CLK driver on an as-needed basis, see 378 + * tegra30_cpu_clock_resume(). 379 + */ 375 380 tegra_get_soc_id TEGRA_APB_MISC_BASE, r1 376 381 cmp r1, #TEGRA30 377 382 beq 1f 383 + 384 + pll_locked r1, r0, CLK_RESET_PLLX_BASE 378 385 379 386 ldr r1, [r0, #CLK_RESET_PLLP_BASE] 380 387 bic r1, r1, #(1<<31) @ disable PllP bypass