Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

drm/mediatek: Set sensible cursor width/height values to fix crash

Hardware-speaking, there is no feature-reduced cursor specific
plane, so this driver reserves the last all Overlay plane as a
Cursor plane, but sets the maximum cursor width/height to the
maximum value that the full overlay plane can use.

While this could be ok, it raises issues with common userspace
using libdrm (especially Mutter, but other compositors too) which
will crash upon performing allocations and/or using said cursor
plane.

Reduce the maximum width/height for the cursor to 512x512 pixels,
value taken from IGT's maximum cursor size test, which succeeds.

Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Reviewed-by: Fei Shao <fshao@chromium.org>
Tested-by: Fei Shao <fshao@chromium.org>
Reviewed-by: Daniel Stone <daniels@collabora.com>
Reviewed-by: CK Hu <ck.hu@mediatek.com>
Link: https://patchwork.kernel.org/project/dri-devel/patch/20240718082410.204459-1-angelogioacchino.delregno@collabora.com/
Signed-off-by: Chun-Kuang Hu <chunkuang.hu@kernel.org>

authored by

AngeloGioacchino Del Regno and committed by
Chun-Kuang Hu
042b8711 8400291e

+2 -2
+2 -2
drivers/gpu/drm/mediatek/mtk_drm_drv.c
··· 539 539 } 540 540 541 541 /* IGT will check if the cursor size is configured */ 542 - drm->mode_config.cursor_width = drm->mode_config.max_width; 543 - drm->mode_config.cursor_height = drm->mode_config.max_height; 542 + drm->mode_config.cursor_width = 512; 543 + drm->mode_config.cursor_height = 512; 544 544 545 545 /* Use OVL device for all DMA memory allocations */ 546 546 crtc = drm_crtc_from_index(drm, 0);