Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

NFS: Remove fscache specific trace points and NFS_INO_FSCACHE bit

The NFS specific trace points are no longer needed as tracing is well
covered by netfs and fscache.

Signed-off-by: Dave Wysochanski <dwysocha@redhat.com>
Reviewed-by: Jeff Layton <jlayton@kernel.org>
Tested-by: Daire Byrne <daire@dneg.com>
Signed-off-by: Anna Schumaker <Anna.Schumaker@Netapp.com>

authored by

Dave Wysochanski and committed by
Anna Schumaker
03f5bd75 0631d5e0

-92
-91
fs/nfs/nfstrace.h
··· 39 39 { BIT(NFS_INO_STALE), "STALE" }, \ 40 40 { BIT(NFS_INO_ACL_LRU_SET), "ACL_LRU_SET" }, \ 41 41 { BIT(NFS_INO_INVALIDATING), "INVALIDATING" }, \ 42 - { BIT(NFS_INO_FSCACHE), "FSCACHE" }, \ 43 42 { BIT(NFS_INO_LAYOUTCOMMIT), "NEED_LAYOUTCOMMIT" }, \ 44 43 { BIT(NFS_INO_LAYOUTCOMMITTING), "LAYOUTCOMMIT" }, \ 45 44 { BIT(NFS_INO_LAYOUTSTATS), "LAYOUTSTATS" }, \ ··· 1242 1243 ) 1243 1244 ); 1244 1245 1245 - DECLARE_EVENT_CLASS(nfs_fscache_page_event, 1246 - TP_PROTO( 1247 - const struct inode *inode, 1248 - struct page *page 1249 - ), 1250 - 1251 - TP_ARGS(inode, page), 1252 - 1253 - TP_STRUCT__entry( 1254 - __field(dev_t, dev) 1255 - __field(u32, fhandle) 1256 - __field(u64, fileid) 1257 - __field(loff_t, offset) 1258 - ), 1259 - 1260 - TP_fast_assign( 1261 - const struct nfs_inode *nfsi = NFS_I(inode); 1262 - const struct nfs_fh *fh = &nfsi->fh; 1263 - 1264 - __entry->offset = page_index(page) << PAGE_SHIFT; 1265 - __entry->dev = inode->i_sb->s_dev; 1266 - __entry->fileid = nfsi->fileid; 1267 - __entry->fhandle = nfs_fhandle_hash(fh); 1268 - ), 1269 - 1270 - TP_printk( 1271 - "fileid=%02x:%02x:%llu fhandle=0x%08x " 1272 - "offset=%lld", 1273 - MAJOR(__entry->dev), MINOR(__entry->dev), 1274 - (unsigned long long)__entry->fileid, 1275 - __entry->fhandle, 1276 - (long long)__entry->offset 1277 - ) 1278 - ); 1279 - DECLARE_EVENT_CLASS(nfs_fscache_page_event_done, 1280 - TP_PROTO( 1281 - const struct inode *inode, 1282 - struct page *page, 1283 - int error 1284 - ), 1285 - 1286 - TP_ARGS(inode, page, error), 1287 - 1288 - TP_STRUCT__entry( 1289 - __field(int, error) 1290 - __field(dev_t, dev) 1291 - __field(u32, fhandle) 1292 - __field(u64, fileid) 1293 - __field(loff_t, offset) 1294 - ), 1295 - 1296 - TP_fast_assign( 1297 - const struct nfs_inode *nfsi = NFS_I(inode); 1298 - const struct nfs_fh *fh = &nfsi->fh; 1299 - 1300 - __entry->offset = page_index(page) << PAGE_SHIFT; 1301 - __entry->dev = inode->i_sb->s_dev; 1302 - __entry->fileid = nfsi->fileid; 1303 - __entry->fhandle = nfs_fhandle_hash(fh); 1304 - __entry->error = error; 1305 - ), 1306 - 1307 - TP_printk( 1308 - "fileid=%02x:%02x:%llu fhandle=0x%08x " 1309 - "offset=%lld error=%d", 1310 - MAJOR(__entry->dev), MINOR(__entry->dev), 1311 - (unsigned long long)__entry->fileid, 1312 - __entry->fhandle, 1313 - (long long)__entry->offset, __entry->error 1314 - ) 1315 - ); 1316 - #define DEFINE_NFS_FSCACHE_PAGE_EVENT(name) \ 1317 - DEFINE_EVENT(nfs_fscache_page_event, name, \ 1318 - TP_PROTO( \ 1319 - const struct inode *inode, \ 1320 - struct page *page \ 1321 - ), \ 1322 - TP_ARGS(inode, page)) 1323 - #define DEFINE_NFS_FSCACHE_PAGE_EVENT_DONE(name) \ 1324 - DEFINE_EVENT(nfs_fscache_page_event_done, name, \ 1325 - TP_PROTO( \ 1326 - const struct inode *inode, \ 1327 - struct page *page, \ 1328 - int error \ 1329 - ), \ 1330 - TP_ARGS(inode, page, error)) 1331 - DEFINE_NFS_FSCACHE_PAGE_EVENT(nfs_fscache_read_page); 1332 - DEFINE_NFS_FSCACHE_PAGE_EVENT_DONE(nfs_fscache_read_page_exit); 1333 - DEFINE_NFS_FSCACHE_PAGE_EVENT(nfs_fscache_write_page); 1334 - DEFINE_NFS_FSCACHE_PAGE_EVENT_DONE(nfs_fscache_write_page_exit); 1335 1246 1336 1247 TRACE_EVENT(nfs_pgio_error, 1337 1248 TP_PROTO(
-1
include/linux/nfs_fs.h
··· 281 281 #define NFS_INO_ACL_LRU_SET (2) /* Inode is on the LRU list */ 282 282 #define NFS_INO_INVALIDATING (3) /* inode is being invalidated */ 283 283 #define NFS_INO_PRESERVE_UNLINKED (4) /* preserve file if removed while open */ 284 - #define NFS_INO_FSCACHE (5) /* inode can be cached by FS-Cache */ 285 284 #define NFS_INO_LAYOUTCOMMIT (9) /* layoutcommit required */ 286 285 #define NFS_INO_LAYOUTCOMMITTING (10) /* layoutcommit inflight */ 287 286 #define NFS_INO_LAYOUTSTATS (11) /* layoutstats inflight */