Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

mm: migrate: fix return value if all subpages of THPs are migrated successfully

During THP migration, if THPs are not migrated but they are split and all
subpages are migrated successfully, migrate_pages() will still return the
number of THP pages that were not migrated. This will confuse the callers
of migrate_pages(). For example, the longterm pinning will failed though
all pages are migrated successfully.

Thus we should return 0 to indicate that all pages are migrated in this
case

Link: https://lkml.kernel.org/r/de386aa864be9158d2f3b344091419ea7c38b2f7.1666599848.git.baolin.wang@linux.alibaba.com
Fixes: b5bade978e9b ("mm: migrate: fix the return value of migrate_pages()")
Signed-off-by: Baolin Wang <baolin.wang@linux.alibaba.com>
Reviewed-by: Alistair Popple <apopple@nvidia.com>
Reviewed-by: Yang Shi <shy828301@gmail.com>
Cc: David Hildenbrand <david@redhat.com>
Cc: "Huang, Ying" <ying.huang@intel.com>
Cc: Zi Yan <ziy@nvidia.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

authored by

Baolin Wang and committed by
Andrew Morton
03e5f82e 67eae54b

+7
+7
mm/migrate.c
··· 1582 1582 */ 1583 1583 list_splice(&ret_pages, from); 1584 1584 1585 + /* 1586 + * Return 0 in case all subpages of fail-to-migrate THPs are 1587 + * migrated successfully. 1588 + */ 1589 + if (list_empty(from)) 1590 + rc = 0; 1591 + 1585 1592 count_vm_events(PGMIGRATE_SUCCESS, nr_succeeded); 1586 1593 count_vm_events(PGMIGRATE_FAIL, nr_failed_pages); 1587 1594 count_vm_events(THP_MIGRATION_SUCCESS, nr_thp_succeeded);