Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

i2c: busses with dynamic ids should start after fixed ids for DT

Make sure dynamic ids do not interfere with fixed ones and let them
start after the highest fixed id. This patch might cause different
bus-numbers than before for dynamic ids, however it fixes a bug. Assume:

- fixed id0 defers probe
- fixed id1 succeeds and registers a muxed bus with dynamic id
- muxed bus gets id0
- fixed id0 wants to probe again, but its fixed id is gone now
- fixed id0 probe fails

With this patch, the fixed ids are always reserved in the DT case.
For legacy board init, we already have a mechanism like this in
i2c_register_board_info().

Reported-by: Bob Feretich <bob.feretich@rafresearch.com>
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>

authored by

Wolfram Sang and committed by
Wolfram Sang
03bde7c3 351d224f

+7
+7
drivers/i2c/i2c-core.c
··· 1878 1878 { 1879 1879 int retval; 1880 1880 1881 + retval = of_alias_get_highest_id("i2c"); 1882 + 1883 + down_write(&__i2c_board_lock); 1884 + if (retval >= __i2c_first_dynamic_bus_num) 1885 + __i2c_first_dynamic_bus_num = retval + 1; 1886 + up_write(&__i2c_board_lock); 1887 + 1881 1888 retval = bus_register(&i2c_bus_type); 1882 1889 if (retval) 1883 1890 return retval;