Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

dummycon: Trigger redraw when switching consoles with deferred takeover

Signal vt subsystem to redraw console when switching to dummycon
with deferred takeover enabled. Makes the console switch to fbcon
and displays the available output.

With deferred takeover enabled, dummycon acts as the placeholder
until the first output to the console happens. At that point, fbcon
takes over. If the output happens while dummycon is not active, it
cannot inform fbcon. This is the case if the vt subsystem runs in
graphics mode.

A typical graphical boot starts plymouth, a display manager and a
compositor; all while leaving out dummycon. Switching to a text-mode
console leaves the console with dummycon even if a getty terminal
has been started.

Returning true from dummycon's con_switch helper signals the vt
subsystem to redraw the screen. If there's output available dummycon's
con_putc{s} helpers trigger deferred takeover of fbcon, which sets a
display mode and displays the output. If no output is available,
dummycon remains active.

v2:
- make the comment slightly more verbose (Javier)

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Reported-by: Andrei Borzenkov <arvidjaar@gmail.com>
Closes: https://bugzilla.suse.com/show_bug.cgi?id=1242191
Tested-by: Andrei Borzenkov <arvidjaar@gmail.com>
Acked-by: Javier Martinez Canillas <javierm@redhat.com>
Fixes: 83d83bebf401 ("console/fbcon: Add support for deferred console takeover")
Cc: Hans de Goede <hdegoede@redhat.com>
Cc: linux-fbdev@vger.kernel.org
Cc: dri-devel@lists.freedesktop.org
Cc: <stable@vger.kernel.org> # v4.19+
Link: https://lore.kernel.org/r/20250520071418.8462-1-tzimmermann@suse.de

+13 -5
+13 -5
drivers/video/console/dummycon.c
··· 85 85 /* Redraw, so that we get putc(s) for output done while blanked */ 86 86 return true; 87 87 } 88 + 89 + static bool dummycon_switch(struct vc_data *vc) 90 + { 91 + /* 92 + * Redraw, so that we get putc(s) for output done while switched 93 + * away. Informs deferred consoles to take over the display. 94 + */ 95 + return true; 96 + } 88 97 #else 89 98 static void dummycon_putc(struct vc_data *vc, u16 c, unsigned int y, 90 99 unsigned int x) { } ··· 101 92 unsigned int ypos, unsigned int xpos) { } 102 93 static bool dummycon_blank(struct vc_data *vc, enum vesa_blank_mode blank, 103 94 bool mode_switch) 95 + { 96 + return false; 97 + } 98 + static bool dummycon_switch(struct vc_data *vc) 104 99 { 105 100 return false; 106 101 } ··· 133 120 static bool dummycon_scroll(struct vc_data *vc, unsigned int top, 134 121 unsigned int bottom, enum con_scroll dir, 135 122 unsigned int lines) 136 - { 137 - return false; 138 - } 139 - 140 - static bool dummycon_switch(struct vc_data *vc) 141 123 { 142 124 return false; 143 125 }