Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

tcp: tcp_enter_quickack_mode() should be static

After commit d2ccd7bc8acd ("tcp: avoid resetting ACK timer in DCTCP"),
tcp_enter_quickack_mode() is only used from net/ipv4/tcp_input.c.

Fixes: d2ccd7bc8acd ("tcp: avoid resetting ACK timer in DCTCP")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Yuchung Cheng <ycheng@google.com>
Cc: Neal Cardwell <ncardwell@google.com>
Link: https://lore.kernel.org/r/20230718162049.1444938-1-edumazet@google.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

authored by

Eric Dumazet and committed by
Jakub Kicinski
03b123de 730b9051

+1 -3
-1
include/net/tcp.h
··· 350 350 struct sk_buff *tcp_stream_alloc_skb(struct sock *sk, gfp_t gfp, 351 351 bool force_schedule); 352 352 353 - void tcp_enter_quickack_mode(struct sock *sk, unsigned int max_quickacks); 354 353 static inline void tcp_dec_quickack_mode(struct sock *sk, 355 354 const unsigned int pkts) 356 355 {
+1 -2
net/ipv4/tcp_input.c
··· 297 297 icsk->icsk_ack.quick = quickacks; 298 298 } 299 299 300 - void tcp_enter_quickack_mode(struct sock *sk, unsigned int max_quickacks) 300 + static void tcp_enter_quickack_mode(struct sock *sk, unsigned int max_quickacks) 301 301 { 302 302 struct inet_connection_sock *icsk = inet_csk(sk); 303 303 ··· 305 305 inet_csk_exit_pingpong_mode(sk); 306 306 icsk->icsk_ack.ato = TCP_ATO_MIN; 307 307 } 308 - EXPORT_SYMBOL(tcp_enter_quickack_mode); 309 308 310 309 /* Send ACKs quickly, if "quick" count is not exhausted 311 310 * and the session is not interactive.