Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

media: omap3isp: Fix missing unlock in isp_subdev_notifier_complete()

Add the missing unlock before return from function
isp_subdev_notifier_complete() in the init error
handling case.

Fixes: ba689d933361 ("media: omap3isp: Acquire graph mutex for graph traversal")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>

authored by

Wei Yongjun and committed by
Mauro Carvalho Chehab
0368e7d2 e006558f

+3 -1
+3 -1
drivers/media/platform/omap3isp/isp.c
··· 2037 2037 mutex_lock(&isp->media_dev.graph_mutex); 2038 2038 2039 2039 ret = media_entity_enum_init(&isp->crashed, &isp->media_dev); 2040 - if (ret) 2040 + if (ret) { 2041 + mutex_unlock(&isp->media_dev.graph_mutex); 2041 2042 return ret; 2043 + } 2042 2044 2043 2045 list_for_each_entry(sd, &v4l2_dev->subdevs, list) { 2044 2046 if (sd->notifier != &isp->notifier)