Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

devlink: region: correct port region lookup to use port_ops

The function devlink_port_region_get_by_name() incorrectly uses
region->ops->name to compare the region name. as it is not any critical
impact as ops and port_ops define as union for devlink_region but as per
code logic it should refer port_ops here.

No functional impact as ops and port_ops are part of same union,
and name is the first member of both.

Update it to use region->port_ops->name to properly reference
the name of the devlink port region.

Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com>
Reviewed-by: Jiri Pirko <jiri@nvidia.com>
Link: https://patch.msgid.link/20251020170916.1741808-1-alok.a.tiwari@oracle.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

authored by

Alok Tiwari and committed by
Jakub Kicinski
0364ca33 3ff9bcec

+1 -1
+1 -1
net/devlink/region.c
··· 50 50 struct devlink_region *region; 51 51 52 52 list_for_each_entry(region, &port->region_list, list) 53 - if (!strcmp(region->ops->name, region_name)) 53 + if (!strcmp(region->port_ops->name, region_name)) 54 54 return region; 55 55 56 56 return NULL;