Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

Input: mc13783_ts - convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.
To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new() which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20230920125829.1478827-47-u.kleine-koenig@pengutronix.de
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>

authored by

Uwe Kleine-König and committed by
Dmitry Torokhov
02fd95e1 02bb3eca

+2 -4
+2 -4
drivers/input/touchscreen/mc13783_ts.c
··· 217 217 return ret; 218 218 } 219 219 220 - static int mc13783_ts_remove(struct platform_device *pdev) 220 + static void mc13783_ts_remove(struct platform_device *pdev) 221 221 { 222 222 struct mc13783_ts_priv *priv = platform_get_drvdata(pdev); 223 223 224 224 input_unregister_device(priv->idev); 225 225 kfree(priv); 226 - 227 - return 0; 228 226 } 229 227 230 228 static struct platform_driver mc13783_ts_driver = { 231 - .remove = mc13783_ts_remove, 229 + .remove_new = mc13783_ts_remove, 232 230 .driver = { 233 231 .name = MC13783_TS_NAME, 234 232 },