Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/drzeus/mmc

* 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/drzeus/mmc:
mmc: struct device - replace bus_id with dev_name(), dev_set_name()
mmc: increase SD write timeout for crappy cards

+22 -21
+1 -2
drivers/mmc/core/bus.c
··· 216 int ret; 217 const char *type; 218 219 - snprintf(card->dev.bus_id, sizeof(card->dev.bus_id), 220 - "%s:%04x", mmc_hostname(card->host), card->rca); 221 222 switch (card->type) { 223 case MMC_TYPE_MMC:
··· 216 int ret; 217 const char *type; 218 219 + dev_set_name(&card->dev, "%s:%04x", mmc_hostname(card->host), card->rca); 220 221 switch (card->type) { 222 case MMC_TYPE_MMC:
+5 -1
drivers/mmc/core/core.c
··· 280 (card->host->ios.clock / 1000); 281 282 if (data->flags & MMC_DATA_WRITE) 283 - limit_us = 250000; 284 else 285 limit_us = 100000; 286
··· 280 (card->host->ios.clock / 1000); 281 282 if (data->flags & MMC_DATA_WRITE) 283 + /* 284 + * The limit is really 250 ms, but that is 285 + * insufficient for some crappy cards. 286 + */ 287 + limit_us = 300000; 288 else 289 limit_us = 100000; 290
+2 -3
drivers/mmc/core/host.c
··· 73 if (err) 74 goto free; 75 76 - snprintf(host->class_dev.bus_id, BUS_ID_SIZE, 77 - "mmc%d", host->index); 78 79 host->parent = dev; 80 host->class_dev.parent = dev; ··· 120 WARN_ON((host->caps & MMC_CAP_SDIO_IRQ) && 121 !host->ops->enable_sdio_irq); 122 123 - led_trigger_register_simple(host->class_dev.bus_id, &host->led); 124 125 err = device_add(&host->class_dev); 126 if (err)
··· 73 if (err) 74 goto free; 75 76 + dev_set_name(&host->class_dev, "mmc%d", host->index); 77 78 host->parent = dev; 79 host->class_dev.parent = dev; ··· 121 WARN_ON((host->caps & MMC_CAP_SDIO_IRQ) && 122 !host->ops->enable_sdio_irq); 123 124 + led_trigger_register_simple(dev_name(&host->class_dev), &host->led); 125 126 err = device_add(&host->class_dev); 127 if (err)
+1 -2
drivers/mmc/core/sdio_bus.c
··· 239 { 240 int ret; 241 242 - snprintf(func->dev.bus_id, sizeof(func->dev.bus_id), 243 - "%s:%d", mmc_card_id(func->card), func->num); 244 245 ret = device_add(&func->dev); 246 if (ret == 0)
··· 239 { 240 int ret; 241 242 + dev_set_name(&func->dev, "%s:%d", mmc_card_id(func->card), func->num); 243 244 ret = device_add(&func->dev); 245 if (ret == 0)
+1 -1
drivers/mmc/host/mmc_spi.c
··· 1348 goto fail_add_host; 1349 1350 dev_info(&spi->dev, "SD/MMC host %s%s%s%s%s\n", 1351 - mmc->class_dev.bus_id, 1352 host->dma_dev ? "" : ", no DMA", 1353 (host->pdata && host->pdata->get_ro) 1354 ? "" : ", no WP",
··· 1348 goto fail_add_host; 1349 1350 dev_info(&spi->dev, "SD/MMC host %s%s%s%s%s\n", 1351 + dev_name(&mmc->class_dev), 1352 host->dma_dev ? "" : ", no DMA", 1353 (host->pdata && host->pdata->get_ro) 1354 ? "" : ", no WP",
+1 -1
drivers/mmc/host/sdhci.c
··· 1733 mmc_add_host(mmc); 1734 1735 printk(KERN_INFO "%s: SDHCI controller on %s [%s] using %s%s\n", 1736 - mmc_hostname(mmc), host->hw_name, mmc_dev(mmc)->bus_id, 1737 (host->flags & SDHCI_USE_ADMA)?"A":"", 1738 (host->flags & SDHCI_USE_DMA)?"DMA":"PIO"); 1739
··· 1733 mmc_add_host(mmc); 1734 1735 printk(KERN_INFO "%s: SDHCI controller on %s [%s] using %s%s\n", 1736 + mmc_hostname(mmc), host->hw_name, dev_name(mmc_dev(mmc)), 1737 (host->flags & SDHCI_USE_ADMA)?"A":"", 1738 (host->flags & SDHCI_USE_DMA)?"DMA":"PIO"); 1739
+8 -8
drivers/mmc/host/tifm_sd.c
··· 632 633 if (host->req) { 634 printk(KERN_ERR "%s : unfinished request detected\n", 635 - sock->dev.bus_id); 636 mrq->cmd->error = -ETIMEDOUT; 637 goto err_out; 638 } ··· 672 ? PCI_DMA_TODEVICE 673 : PCI_DMA_FROMDEVICE)) { 674 printk(KERN_ERR "%s : scatterlist map failed\n", 675 - sock->dev.bus_id); 676 mrq->cmd->error = -ENOMEM; 677 goto err_out; 678 } ··· 684 : PCI_DMA_FROMDEVICE); 685 if (host->sg_len < 1) { 686 printk(KERN_ERR "%s : scatterlist map failed\n", 687 - sock->dev.bus_id); 688 tifm_unmap_sg(sock, &host->bounce_buf, 1, 689 r_data->flags & MMC_DATA_WRITE 690 ? PCI_DMA_TODEVICE ··· 748 749 if (!mrq) { 750 printk(KERN_ERR " %s : no request to complete?\n", 751 - sock->dev.bus_id); 752 spin_unlock_irqrestore(&sock->lock, flags); 753 return; 754 } ··· 789 printk(KERN_ERR 790 "%s : card failed to respond for a long period of time " 791 "(%x, %x)\n", 792 - host->dev->dev.bus_id, host->req->cmd->opcode, host->cmd_flags); 793 794 tifm_eject(host->dev); 795 } ··· 906 907 if (rc) { 908 printk(KERN_ERR "%s : controller failed to reset\n", 909 - sock->dev.bus_id); 910 return -ENODEV; 911 } 912 ··· 933 if (rc) { 934 printk(KERN_ERR 935 "%s : card not ready - probe failed on initialization\n", 936 - sock->dev.bus_id); 937 return -ENODEV; 938 } 939 ··· 954 if (!(TIFM_SOCK_STATE_OCCUPIED 955 & readl(sock->addr + SOCK_PRESENT_STATE))) { 956 printk(KERN_WARNING "%s : card gone, unexpectedly\n", 957 - sock->dev.bus_id); 958 return rc; 959 } 960
··· 632 633 if (host->req) { 634 printk(KERN_ERR "%s : unfinished request detected\n", 635 + dev_name(&sock->dev)); 636 mrq->cmd->error = -ETIMEDOUT; 637 goto err_out; 638 } ··· 672 ? PCI_DMA_TODEVICE 673 : PCI_DMA_FROMDEVICE)) { 674 printk(KERN_ERR "%s : scatterlist map failed\n", 675 + dev_name(&sock->dev)); 676 mrq->cmd->error = -ENOMEM; 677 goto err_out; 678 } ··· 684 : PCI_DMA_FROMDEVICE); 685 if (host->sg_len < 1) { 686 printk(KERN_ERR "%s : scatterlist map failed\n", 687 + dev_name(&sock->dev)); 688 tifm_unmap_sg(sock, &host->bounce_buf, 1, 689 r_data->flags & MMC_DATA_WRITE 690 ? PCI_DMA_TODEVICE ··· 748 749 if (!mrq) { 750 printk(KERN_ERR " %s : no request to complete?\n", 751 + dev_name(&sock->dev)); 752 spin_unlock_irqrestore(&sock->lock, flags); 753 return; 754 } ··· 789 printk(KERN_ERR 790 "%s : card failed to respond for a long period of time " 791 "(%x, %x)\n", 792 + dev_name(&host->dev->dev), host->req->cmd->opcode, host->cmd_flags); 793 794 tifm_eject(host->dev); 795 } ··· 906 907 if (rc) { 908 printk(KERN_ERR "%s : controller failed to reset\n", 909 + dev_name(&sock->dev)); 910 return -ENODEV; 911 } 912 ··· 933 if (rc) { 934 printk(KERN_ERR 935 "%s : card not ready - probe failed on initialization\n", 936 + dev_name(&sock->dev)); 937 return -ENODEV; 938 } 939 ··· 954 if (!(TIFM_SOCK_STATE_OCCUPIED 955 & readl(sock->addr + SOCK_PRESENT_STATE))) { 956 printk(KERN_WARNING "%s : card gone, unexpectedly\n", 957 + dev_name(&sock->dev)); 958 return rc; 959 } 960
+1 -1
include/linux/mmc/card.h
··· 130 #define mmc_card_set_blockaddr(c) ((c)->state |= MMC_STATE_BLOCKADDR) 131 132 #define mmc_card_name(c) ((c)->cid.prod_name) 133 - #define mmc_card_id(c) ((c)->dev.bus_id) 134 135 #define mmc_list_to_card(l) container_of(l, struct mmc_card, node) 136 #define mmc_get_drvdata(c) dev_get_drvdata(&(c)->dev)
··· 130 #define mmc_card_set_blockaddr(c) ((c)->state |= MMC_STATE_BLOCKADDR) 131 132 #define mmc_card_name(c) ((c)->cid.prod_name) 133 + #define mmc_card_id(c) (dev_name(&(c)->dev)) 134 135 #define mmc_list_to_card(l) container_of(l, struct mmc_card, node) 136 #define mmc_get_drvdata(c) dev_get_drvdata(&(c)->dev)
+1 -1
include/linux/mmc/host.h
··· 176 177 #define mmc_dev(x) ((x)->parent) 178 #define mmc_classdev(x) (&(x)->class_dev) 179 - #define mmc_hostname(x) ((x)->class_dev.bus_id) 180 181 extern int mmc_suspend_host(struct mmc_host *, pm_message_t); 182 extern int mmc_resume_host(struct mmc_host *);
··· 176 177 #define mmc_dev(x) ((x)->parent) 178 #define mmc_classdev(x) (&(x)->class_dev) 179 + #define mmc_hostname(x) (dev_name(&(x)->class_dev)) 180 181 extern int mmc_suspend_host(struct mmc_host *, pm_message_t); 182 extern int mmc_resume_host(struct mmc_host *);
+1 -1
include/linux/mmc/sdio_func.h
··· 63 64 #define sdio_func_set_present(f) ((f)->state |= SDIO_STATE_PRESENT) 65 66 - #define sdio_func_id(f) ((f)->dev.bus_id) 67 68 #define sdio_get_drvdata(f) dev_get_drvdata(&(f)->dev) 69 #define sdio_set_drvdata(f,d) dev_set_drvdata(&(f)->dev, d)
··· 63 64 #define sdio_func_set_present(f) ((f)->state |= SDIO_STATE_PRESENT) 65 66 + #define sdio_func_id(f) (dev_name(&(f)->dev)) 67 68 #define sdio_get_drvdata(f) dev_get_drvdata(&(f)->dev) 69 #define sdio_set_drvdata(f,d) dev_set_drvdata(&(f)->dev, d)