Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

sysfs: introduce __SYSFS_FUNCTION_ALTERNATIVE()

For the constification phase of 'struct attribute' various callback
struct members will need to exist in both const and non-const variants.
Keeping both members in a union avoids memory and CPU overhead but will
be detected and trapped by Control Flow Integrity (CFI). By deciding
between a struct and a union depending whether CFI is enabled, most
configurations can avoid this overhead. Code using these callbacks will
still need to be updated to handle both members explicitly.
In the union case the compiler will recognize that testing for one union
member is enough and optimize away the code for the other one.

Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
Link: https://patch.msgid.link/20251029-sysfs-const-attr-prep-v5-3-ea7d745acff4@weissschuh.net
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

authored by

Thomas Weißschuh and committed by
Greg Kroah-Hartman
02ac5335 964c93b1

+6
+6
include/linux/sysfs.h
··· 58 58 #define sysfs_attr_init(attr) do {} while (0) 59 59 #endif 60 60 61 + #ifdef CONFIG_CFI 62 + #define __SYSFS_FUNCTION_ALTERNATIVE(MEMBERS...) struct { MEMBERS } 63 + #else 64 + #define __SYSFS_FUNCTION_ALTERNATIVE(MEMBERS...) union { MEMBERS } 65 + #endif 66 + 61 67 /** 62 68 * struct attribute_group - data structure used to declare an attribute group. 63 69 * @name: Optional: Attribute group name