Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

net: phy: mdio: add missing of_node_put

for_each_available_child_of_node performs an of_node_get on each iteration, so
a break out of the loop requires an of_node_put.

A simplified version of the semantic patch that fixes this problem is as
follows (http://coccinelle.lip6.fr):

// <smpl>
@@
expression root,e;
local idexpression child;
@@

for_each_available_child_of_node(root, child) {
... when != of_node_put(child)
when != e = child
(
return child;
|
+ of_node_put(child);
? return ...;
)
...
}
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: David S. Miller <davem@davemloft.net>

authored by

Julia Lawall and committed by
David S. Miller
02862341 447ed736

+2
+2
drivers/net/phy/mdio-mux-mmioreg.c
··· 113 113 if (!iprop || len != sizeof(uint32_t)) { 114 114 dev_err(&pdev->dev, "mdio-mux child node %s is " 115 115 "missing a 'reg' property\n", np2->full_name); 116 + of_node_put(np2); 116 117 return -ENODEV; 117 118 } 118 119 if (be32_to_cpup(iprop) & ~s->mask) { 119 120 dev_err(&pdev->dev, "mdio-mux child node %s has " 120 121 "a 'reg' value with unmasked bits\n", 121 122 np2->full_name); 123 + of_node_put(np2); 122 124 return -ENODEV; 123 125 } 124 126 }