Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

firewire: fix warnings to generate UAPI documentation

Any target to generate UAPI documentation reports warnings to missing
annotation for padding member in structures added recently.

This commit suppresses the warnings.

Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Closes: https://lore.kernel.org/lkml/20230531135306.43613a59@canb.auug.org.au/
Fixes: 7c22d4a92bb2 ("firewire: cdev: add new event to notify request subaction with time stamp")
Fixes: fc2b52cf2e0e ("firewire: cdev: add new event to notify response subaction with time stamp")
Link: https://lore.kernel.org/r/20230601144937.121179-1-o-takashi@sakamocchi.jp
Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>

+6 -8
+6 -8
include/uapi/linux/firewire-cdev.h
··· 130 130 * @length: Data length, i.e. the response's payload size in bytes 131 131 * @request_tstamp: The time stamp of isochronous cycle at which the request was sent. 132 132 * @response_tstamp: The time stamp of isochronous cycle at which the response was sent. 133 + * @padding: Padding to keep the size of structure as multiples of 8 in various architectures 134 + * since 4 byte alignment is used for 8 byte of object type in System V ABI for i386 135 + * architecture. 133 136 * @data: Payload data, if any 134 137 * 135 138 * This event is sent when the stack receives a response to an outgoing request ··· 158 155 __u32 length; 159 156 __u32 request_tstamp; 160 157 __u32 response_tstamp; 161 - /* 162 - * Padding to keep the size of structure as multiples of 8 in various architectures since 163 - * 4 byte alignment is used for 8 byte of object type in System V ABI for i386 architecture. 164 - */ 165 158 __u32 padding; 166 159 __u32 data[]; 167 160 }; ··· 230 231 * @handle: Reference to the kernel-side pending request 231 232 * @length: Data length, i.e. the request's payload size in bytes 232 233 * @tstamp: The time stamp of isochronous cycle at which the request arrived. 234 + * @padding: Padding to keep the size of structure as multiples of 8 in various architectures 235 + * since 4 byte alignment is used for 8 byte of object type in System V ABI for i386 236 + * architecture. 233 237 * @data: Incoming data, if any 234 238 * 235 239 * This event is sent when the stack receives an incoming request to an address ··· 286 284 __u32 handle; 287 285 __u32 length; 288 286 __u32 tstamp; 289 - /* 290 - * Padding to keep the size of structure as multiples of 8 in various architectures since 291 - * 4 byte alignment is used for 8 byte of object type in System V ABI for i386 architecture. 292 - */ 293 287 __u32 padding; 294 288 __u32 data[]; 295 289 };