zd1211rw: reset rx idle timer from tasklet

2.6.38 added WARN_ON(in_irq) in del_timer_sync that triggers on zd1211rw when
reseting rx idle timer in urb completion handler.

Move timer reseting to tasklet.

Signed-off-by: Jussi Kivilinna <jussi.kivilinna@mbnet.fi>
Signed-off-by: John W. Linville <linville@tuxdriver.com>

authored by Jussi Kivilinna and committed by John W. Linville 02353573 2fc713b2

+14 -1
+13 -1
drivers/net/wireless/zd1211rw/zd_usb.c
··· 643 usb = urb->context; 644 rx = &usb->rx; 645 646 - zd_usb_reset_rx_idle_timer(usb); 647 648 if (length%rx->usb_packet_size > rx->usb_packet_size-4) { 649 /* If there is an old first fragment, we don't care. */ ··· 812 __zd_usb_disable_rx(usb); 813 mutex_unlock(&rx->setup_mutex); 814 815 cancel_delayed_work_sync(&rx->idle_work); 816 } 817 ··· 1107 zd_usb_reset_rx(usb); 1108 } 1109 1110 void zd_usb_reset_rx_idle_timer(struct zd_usb *usb) 1111 { 1112 struct zd_usb_rx *rx = &usb->rx; ··· 1135 static inline void init_usb_rx(struct zd_usb *usb) 1136 { 1137 struct zd_usb_rx *rx = &usb->rx; 1138 spin_lock_init(&rx->lock); 1139 mutex_init(&rx->setup_mutex); 1140 if (interface_to_usbdev(usb->intf)->speed == USB_SPEED_HIGH) { ··· 1145 } 1146 ZD_ASSERT(rx->fragment_length == 0); 1147 INIT_DELAYED_WORK(&rx->idle_work, zd_rx_idle_timer_handler); 1148 } 1149 1150 static inline void init_usb_tx(struct zd_usb *usb) 1151 { 1152 struct zd_usb_tx *tx = &usb->tx; 1153 spin_lock_init(&tx->lock); 1154 atomic_set(&tx->enabled, 0); 1155 tx->stopped = 0;
··· 643 usb = urb->context; 644 rx = &usb->rx; 645 646 + tasklet_schedule(&rx->reset_timer_tasklet); 647 648 if (length%rx->usb_packet_size > rx->usb_packet_size-4) { 649 /* If there is an old first fragment, we don't care. */ ··· 812 __zd_usb_disable_rx(usb); 813 mutex_unlock(&rx->setup_mutex); 814 815 + tasklet_kill(&rx->reset_timer_tasklet); 816 cancel_delayed_work_sync(&rx->idle_work); 817 } 818 ··· 1106 zd_usb_reset_rx(usb); 1107 } 1108 1109 + static void zd_usb_reset_rx_idle_timer_tasklet(unsigned long param) 1110 + { 1111 + struct zd_usb *usb = (struct zd_usb *)param; 1112 + 1113 + zd_usb_reset_rx_idle_timer(usb); 1114 + } 1115 + 1116 void zd_usb_reset_rx_idle_timer(struct zd_usb *usb) 1117 { 1118 struct zd_usb_rx *rx = &usb->rx; ··· 1127 static inline void init_usb_rx(struct zd_usb *usb) 1128 { 1129 struct zd_usb_rx *rx = &usb->rx; 1130 + 1131 spin_lock_init(&rx->lock); 1132 mutex_init(&rx->setup_mutex); 1133 if (interface_to_usbdev(usb->intf)->speed == USB_SPEED_HIGH) { ··· 1136 } 1137 ZD_ASSERT(rx->fragment_length == 0); 1138 INIT_DELAYED_WORK(&rx->idle_work, zd_rx_idle_timer_handler); 1139 + rx->reset_timer_tasklet.func = zd_usb_reset_rx_idle_timer_tasklet; 1140 + rx->reset_timer_tasklet.data = (unsigned long)usb; 1141 } 1142 1143 static inline void init_usb_tx(struct zd_usb *usb) 1144 { 1145 struct zd_usb_tx *tx = &usb->tx; 1146 + 1147 spin_lock_init(&tx->lock); 1148 atomic_set(&tx->enabled, 0); 1149 tx->stopped = 0;
+1
drivers/net/wireless/zd1211rw/zd_usb.h
··· 183 spinlock_t lock; 184 struct mutex setup_mutex; 185 struct delayed_work idle_work; 186 u8 fragment[2 * USB_MAX_RX_SIZE]; 187 unsigned int fragment_length; 188 unsigned int usb_packet_size;
··· 183 spinlock_t lock; 184 struct mutex setup_mutex; 185 struct delayed_work idle_work; 186 + struct tasklet_struct reset_timer_tasklet; 187 u8 fragment[2 * USB_MAX_RX_SIZE]; 188 unsigned int fragment_length; 189 unsigned int usb_packet_size;