Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

mmc: sdricoh_cs: constify mmc_host_ops structures

The mmc_host_ops structure is only stored in the ops field of an
mmc_host structure, which is declared as const. Thus the mmc_host_ops
structure itself can be const.

Done with the help of Coccinelle.

// <smpl>
@r disable optional_qualifier@
identifier i;
position p;
@@
static struct mmc_host_ops i@p = { ... };

@ok1@
struct mmc_host *mmc;
identifier r.i;
position p;
@@
mmc->ops = &i@p

@bad@
position p != {r.p,ok1.p};
identifier r.i;
struct mmc_host_ops e;
@@
e@i@p

@depends on !bad disable optional_qualifier@
identifier r.i;
@@
static
+const
struct mmc_host_ops i = { ... };
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>

authored by

Julia Lawall and committed by
Ulf Hansson
01fa235c 1f8029c3

+1 -1
+1 -1
drivers/mmc/host/sdricoh_cs.c
··· 385 385 return (status & STATUS_CARD_LOCKED); 386 386 } 387 387 388 - static struct mmc_host_ops sdricoh_ops = { 388 + static const struct mmc_host_ops sdricoh_ops = { 389 389 .request = sdricoh_request, 390 390 .set_ios = sdricoh_set_ios, 391 391 .get_ro = sdricoh_get_ro,