Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

net/mlx4_core: Adjust allocation type for buddy->bits

In preparation for making the kmalloc family of allocators type aware,
we need to make sure that the returned type from the allocation matches
the type of the variable being assigned. (Before, the allocator would
always return "void *", which can be implicitly cast to any pointer type.)

The assigned type is "unsigned long **", but the returned type will be
"long **". These are the same size allocation (pointer size) but the
types do not match. Adjust the allocation type to match the assignment.

Signed-off-by: Kees Cook <kees@kernel.org>
Reviewed-by: Simon Horman <horms@kernel.org>
Reviewed-by: Tariq Toukan <tariqt@nvidia.com>
Link: https://patch.msgid.link/20250426060757.work.865-kees@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

authored by

Kees Cook and committed by
Jakub Kicinski
01cbf838 2eea791a

+1 -1
+1 -1
drivers/net/ethernet/mellanox/mlx4/mr.c
··· 106 106 buddy->max_order = max_order; 107 107 spin_lock_init(&buddy->lock); 108 108 109 - buddy->bits = kcalloc(buddy->max_order + 1, sizeof(long *), 109 + buddy->bits = kcalloc(buddy->max_order + 1, sizeof(*buddy->bits), 110 110 GFP_KERNEL); 111 111 buddy->num_free = kcalloc(buddy->max_order + 1, sizeof(*buddy->num_free), 112 112 GFP_KERNEL);