Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

fbdev: sh_mobile_lcdc: Remove board configuration board_data field

The field is unused, remove it. Update board code accordingly.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

+37 -55
+2 -12
arch/arm/mach-shmobile/board-ag5evm.c
··· 229 229 gpio_set_value(GPIO_PORT235, 1); 230 230 } 231 231 232 - static void lcd_on(void *board_data, struct fb_info *info) 233 - { 234 - lcd_backlight_on(); 235 - } 236 - 237 - static void lcd_off(void *board_data) 238 - { 239 - lcd_backlight_reset(); 240 - } 241 - 242 232 /* LCDC0 */ 243 233 static const struct fb_videomode lcdc0_modes[] = { 244 234 { ··· 258 268 .lcd_cfg = lcdc0_modes, 259 269 .num_cfg = ARRAY_SIZE(lcdc0_modes), 260 270 .board_cfg = { 261 - .display_on = lcd_on, 262 - .display_off = lcd_off, 271 + .display_on = lcd_backlight_on, 272 + .display_off = lcd_backlight_reset, 263 273 }, 264 274 } 265 275 };
+2 -2
arch/arm/mach-shmobile/board-mackerel.c
··· 351 351 }, 352 352 }; 353 353 354 - static int mackerel_set_brightness(void *board_data, int brightness) 354 + static int mackerel_set_brightness(int brightness) 355 355 { 356 356 gpio_set_value(GPIO_PORT31, brightness); 357 357 358 358 return 0; 359 359 } 360 360 361 - static int mackerel_get_brightness(void *board_data) 361 + static int mackerel_get_brightness(void) 362 362 { 363 363 return gpio_get_value(GPIO_PORT31); 364 364 }
+4 -4
arch/sh/boards/mach-ap325rxa/setup.c
··· 157 157 #define PORT_DRVCRA 0xA405018A 158 158 #define PORT_DRVCRB 0xA405018C 159 159 160 - static int ap320_wvga_set_brightness(void *board_data, int brightness) 160 + static int ap320_wvga_set_brightness(int brightness) 161 161 { 162 162 if (brightness) { 163 163 gpio_set_value(GPIO_PTS3, 0); ··· 170 170 return 0; 171 171 } 172 172 173 - static int ap320_wvga_get_brightness(void *board_data) 173 + static int ap320_wvga_get_brightness(void) 174 174 { 175 175 return gpio_get_value(GPIO_PTS3); 176 176 } 177 177 178 - static void ap320_wvga_power_on(void *board_data, struct fb_info *info) 178 + static void ap320_wvga_power_on(void) 179 179 { 180 180 msleep(100); 181 181 ··· 183 183 __raw_writew(FPGA_LCDREG_VAL, FPGA_LCDREG); 184 184 } 185 185 186 - static void ap320_wvga_power_off(void *board_data) 186 + static void ap320_wvga_power_off(void) 187 187 { 188 188 /* ASD AP-320/325 LCD OFF */ 189 189 __raw_writew(0, FPGA_LCDREG);
+2 -2
arch/sh/boards/mach-ecovec24/setup.c
··· 310 310 }, 311 311 }; 312 312 313 - static int ecovec24_set_brightness(void *board_data, int brightness) 313 + static int ecovec24_set_brightness(int brightness) 314 314 { 315 315 gpio_set_value(GPIO_PTR1, brightness); 316 316 317 317 return 0; 318 318 } 319 319 320 - static int ecovec24_get_brightness(void *board_data) 320 + static int ecovec24_get_brightness(void) 321 321 { 322 322 return gpio_get_value(GPIO_PTR1); 323 323 }
+4 -6
arch/sh/boards/mach-kfr2r09/lcd_wqvga.c
··· 251 251 write_memory_start(sohandle, so); 252 252 } 253 253 254 - int kfr2r09_lcd_setup(void *board_data, void *sohandle, 255 - struct sh_mobile_lcdc_sys_bus_ops *so) 254 + int kfr2r09_lcd_setup(void *sohandle, struct sh_mobile_lcdc_sys_bus_ops *so) 256 255 { 257 256 /* power on */ 258 257 gpio_set_value(GPIO_PTF4, 0); /* PROTECT/ -> L */ ··· 272 273 return 0; 273 274 } 274 275 275 - void kfr2r09_lcd_start(void *board_data, void *sohandle, 276 - struct sh_mobile_lcdc_sys_bus_ops *so) 276 + void kfr2r09_lcd_start(void *sohandle, struct sh_mobile_lcdc_sys_bus_ops *so) 277 277 { 278 278 write_memory_start(sohandle, so); 279 279 } ··· 325 327 return 0; 326 328 } 327 329 328 - void kfr2r09_lcd_on(void *board_data, struct fb_info *info) 330 + void kfr2r09_lcd_on(void) 329 331 { 330 332 kfr2r09_lcd_backlight(1); 331 333 } 332 334 333 - void kfr2r09_lcd_off(void *board_data) 335 + void kfr2r09_lcd_off(void) 334 336 { 335 337 kfr2r09_lcd_backlight(0); 336 338 }
+1 -2
arch/sh/boards/mach-migor/lcd_qvga.c
··· 113 113 0x0010, 0x16B0, 0x0011, 0x0111, 0x0007, 0x0061, 114 114 }; 115 115 116 - int migor_lcd_qvga_setup(void *board_data, void *sohandle, 117 - struct sh_mobile_lcdc_sys_bus_ops *so) 116 + int migor_lcd_qvga_setup(void *sohandle, struct sh_mobile_lcdc_sys_bus_ops *so) 118 117 { 119 118 unsigned long xres = 320; 120 119 unsigned long yres = 240;
-2
arch/sh/boards/mach-se/7724/setup.c
··· 186 186 .width = 152, 187 187 .height = 91, 188 188 }, 189 - .board_cfg = { 190 - }, 191 189 } 192 190 }; 193 191
+8 -8
arch/sh/include/mach-kfr2r09/mach/kfr2r09.h
··· 4 4 #include <video/sh_mobile_lcdc.h> 5 5 6 6 #if defined(CONFIG_FB_SH_MOBILE_LCDC) || defined(CONFIG_FB_SH_MOBILE_LCDC_MODULE) 7 - void kfr2r09_lcd_on(void *board_data, struct fb_info *info); 8 - void kfr2r09_lcd_off(void *board_data); 9 - int kfr2r09_lcd_setup(void *board_data, void *sys_ops_handle, 7 + void kfr2r09_lcd_on(void); 8 + void kfr2r09_lcd_off(void); 9 + int kfr2r09_lcd_setup(void *sys_ops_handle, 10 10 struct sh_mobile_lcdc_sys_bus_ops *sys_ops); 11 - void kfr2r09_lcd_start(void *board_data, void *sys_ops_handle, 11 + void kfr2r09_lcd_start(void *sys_ops_handle, 12 12 struct sh_mobile_lcdc_sys_bus_ops *sys_ops); 13 13 #else 14 - static void kfr2r09_lcd_on(void *board_data) {} 15 - static void kfr2r09_lcd_off(void *board_data) {} 16 - static int kfr2r09_lcd_setup(void *board_data, void *sys_ops_handle, 14 + static void kfr2r09_lcd_on(void) {} 15 + static void kfr2r09_lcd_off(void) {} 16 + static int kfr2r09_lcd_setup(void *sys_ops_handle, 17 17 struct sh_mobile_lcdc_sys_bus_ops *sys_ops) 18 18 { 19 19 return -ENODEV; 20 20 } 21 - static void kfr2r09_lcd_start(void *board_data, void *sys_ops_handle, 21 + static void kfr2r09_lcd_start(void *sys_ops_handle, 22 22 struct sh_mobile_lcdc_sys_bus_ops *sys_ops) 23 23 { 24 24 }
+1 -1
arch/sh/include/mach-migor/mach/migor.h
··· 9 9 10 10 #include <video/sh_mobile_lcdc.h> 11 11 12 - int migor_lcd_qvga_setup(void *board_data, void *sys_ops_handle, 12 + int migor_lcd_qvga_setup(void *sys_ops_handle, 13 13 struct sh_mobile_lcdc_sys_bus_ops *sys_ops); 14 14 15 15 #endif /* __ASM_SH_MIGOR_H */
+7 -9
drivers/video/sh_mobile_lcdcfb.c
··· 315 315 /* trigger panel update */ 316 316 dma_map_sg(info->dev, ch->sglist, nr_pages, DMA_TO_DEVICE); 317 317 if (bcfg->start_transfer) 318 - bcfg->start_transfer(bcfg->board_data, ch, 319 - &sh_mobile_lcdc_sys_bus_ops); 318 + bcfg->start_transfer(ch, &sh_mobile_lcdc_sys_bus_ops); 320 319 lcdc_write_chan(ch, LDSM2R, LDSM2R_OSTRG); 321 320 dma_unmap_sg(info->dev, ch->sglist, nr_pages, DMA_TO_DEVICE); 322 321 } else { 323 322 if (bcfg->start_transfer) 324 - bcfg->start_transfer(bcfg->board_data, ch, 325 - &sh_mobile_lcdc_sys_bus_ops); 323 + bcfg->start_transfer(ch, &sh_mobile_lcdc_sys_bus_ops); 326 324 lcdc_write_chan(ch, LDSM2R, LDSM2R_OSTRG); 327 325 } 328 326 } ··· 344 346 345 347 /* HDMI must be enabled before LCDC configuration */ 346 348 if (board_cfg->display_on) 347 - board_cfg->display_on(board_cfg->board_data, ch->info); 349 + board_cfg->display_on(); 348 350 } 349 351 350 352 static void sh_mobile_lcdc_display_off(struct sh_mobile_lcdc_chan *ch) ··· 352 354 struct sh_mobile_lcdc_board_cfg *board_cfg = &ch->cfg.board_cfg; 353 355 354 356 if (board_cfg->display_off) 355 - board_cfg->display_off(board_cfg->board_data); 357 + board_cfg->display_off(); 356 358 357 359 if (ch->tx_dev) 358 360 ch->tx_dev->ops->display_off(ch->tx_dev); ··· 695 697 696 698 board_cfg = &ch->cfg.board_cfg; 697 699 if (board_cfg->setup_sys) { 698 - ret = board_cfg->setup_sys(board_cfg->board_data, ch, 700 + ret = board_cfg->setup_sys(ch, 699 701 &sh_mobile_lcdc_sys_bus_ops); 700 702 if (ret) 701 703 return ret; ··· 1324 1326 bdev->props.state & (BL_CORE_SUSPENDED | BL_CORE_FBBLANK)) 1325 1327 brightness = 0; 1326 1328 1327 - return cfg->set_brightness(cfg->board_data, brightness); 1329 + return cfg->set_brightness(brightness); 1328 1330 } 1329 1331 1330 1332 static int sh_mobile_lcdc_get_brightness(struct backlight_device *bdev) ··· 1332 1334 struct sh_mobile_lcdc_chan *ch = bl_get_data(bdev); 1333 1335 struct sh_mobile_lcdc_board_cfg *cfg = &ch->cfg.board_cfg; 1334 1336 1335 - return cfg->get_brightness(cfg->board_data); 1337 + return cfg->get_brightness(); 1336 1338 } 1337 1339 1338 1340 static int sh_mobile_lcdc_check_fb(struct backlight_device *bdev,
+6 -7
include/video/sh_mobile_lcdc.h
··· 148 148 }; 149 149 150 150 struct sh_mobile_lcdc_board_cfg { 151 - void *board_data; 152 - int (*setup_sys)(void *board_data, void *sys_ops_handle, 151 + int (*setup_sys)(void *sys_ops_handle, 153 152 struct sh_mobile_lcdc_sys_bus_ops *sys_ops); 154 - void (*start_transfer)(void *board_data, void *sys_ops_handle, 153 + void (*start_transfer)(void *sys_ops_handle, 155 154 struct sh_mobile_lcdc_sys_bus_ops *sys_ops); 156 - void (*display_on)(void *board_data, struct fb_info *info); 157 - void (*display_off)(void *board_data); 158 - int (*set_brightness)(void *board_data, int brightness); 159 - int (*get_brightness)(void *board_data); 155 + void (*display_on)(void); 156 + void (*display_off)(void); 157 + int (*set_brightness)(int brightness); 158 + int (*get_brightness)(void); 160 159 }; 161 160 162 161 struct sh_mobile_lcdc_lcd_size_cfg { /* width and height of panel in mm */