Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

USB: serial: mos7840: remove set but not used variables 'number, serial'

Fixes gcc '-Wunused-but-set-variable' warning:

drivers/usb/serial/mos7840.c: In function 'mos7840_send_cmd_write_baud_rate':
drivers/usb/serial/mos7840.c:1584:16: warning:
variable 'number' set but not used [-Wunused-but-set-variable]

drivers/usb/serial/mos7840.c: In function 'mos7840_change_port_settings':
drivers/usb/serial/mos7840.c:1695:21: warning:
variable 'serial' set but not used [-Wunused-but-set-variable]

'number' never used since introduction in commit 3f5429746d91 ("USB: Moschip
7840 USB-Serial Driver")

'serial' not used since commit 5833041f1b13 ("USB: serial: remove unnecessary
reinitialisations of urb->dev")

Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Signed-off-by: Johan Hovold <johan@kernel.org>

authored by

YueHaibing and committed by
Johan Hovold
01688a6d 32899682

-6
-6
drivers/usb/serial/mos7840.c
··· 1581 1581 int divisor = 0; 1582 1582 int status; 1583 1583 __u16 Data; 1584 - unsigned char number; 1585 1584 __u16 clk_sel_val; 1586 1585 struct usb_serial_port *port; 1587 1586 ··· 1593 1594 1594 1595 if (mos7840_serial_paranoia_check(port->serial, __func__)) 1595 1596 return -1; 1596 - 1597 - number = mos7840_port->port->port_number; 1598 1597 1599 1598 dev_dbg(&port->dev, "%s - baud = %d\n", __func__, baudRate); 1600 1599 /* reset clk_uart_sel in spregOffset */ ··· 1689 1692 int status; 1690 1693 __u16 Data; 1691 1694 struct usb_serial_port *port; 1692 - struct usb_serial *serial; 1693 1695 1694 1696 if (mos7840_port == NULL) 1695 1697 return; ··· 1700 1704 1701 1705 if (mos7840_serial_paranoia_check(port->serial, __func__)) 1702 1706 return; 1703 - 1704 - serial = port->serial; 1705 1707 1706 1708 if (!mos7840_port->open) { 1707 1709 dev_dbg(&port->dev, "%s - port not opened\n", __func__);