Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

sparc: refactor code in fault_32.c

The sparc allmodconfig build broke due to enabling of the
branch_tracer that does some very clever things with
all if conditions. This caused my gcc 3.4.5 to be so confused that
it emitted a warning:

arch/sparc/mm/fault_32.c: In function `do_sparc_fault':
arch/sparc/mm/fault_32.c:176: warning: 'fixup' might be used uninitialized in this function

And with -Werror this broke the build.

Refactor code so it:
1) becomes more readable
2) no longer emit a warning with the branch_tracer enabled

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Signed-off-by: David S. Miller <davem@davemloft.net>

authored by

Sam Ravnborg and committed by
David S. Miller
0157141a ff9aefbf

+2 -1
+2 -1
arch/sparc/mm/fault_32.c
··· 283 283 /* Is this in ex_table? */ 284 284 no_context: 285 285 g2 = regs->u_regs[UREG_G2]; 286 - if (!from_user && (fixup = search_extables_range(regs->pc, &g2))) { 286 + if (!from_user) { 287 + fixup = search_extables_range(regs->pc, &g2); 287 288 if (fixup > 10) { /* Values below are reserved for other things */ 288 289 extern const unsigned __memset_start[]; 289 290 extern const unsigned __memset_end[];