Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

ppp: fix out-of-bounds access in bpf_prog_create()

sock_fprog_kern::len is in units of struct sock_filter, not bytes.

Fixes: 3e859adf3643 ("compat_ioctl: unify copy-in of ppp filters")
Reported-by: syzbot+eb853b51b10f1befa0b7@syzkaller.appspotmail.com
Signed-off-by: Eric Biggers <ebiggers@google.com>
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: David S. Miller <davem@davemloft.net>

authored by

Eric Biggers and committed by
David S. Miller
0033b34a a116f4e2

+3 -2
+3 -2
drivers/net/ppp/ppp_generic.c
··· 564 564 return NULL; 565 565 566 566 /* uprog->len is unsigned short, so no overflow here */ 567 - fprog.len = uprog->len * sizeof(struct sock_filter); 568 - fprog.filter = memdup_user(uprog->filter, fprog.len); 567 + fprog.len = uprog->len; 568 + fprog.filter = memdup_user(uprog->filter, 569 + uprog->len * sizeof(struct sock_filter)); 569 570 if (IS_ERR(fprog.filter)) 570 571 return ERR_CAST(fprog.filter); 571 572