tangled.org
UID and GID args can now be set during build,
so following the example command in the README should fix
#2
by providing a UID and GID that exist on the host
so that the directories owned by git in the container
can be bind mounted on the host.
+6
-1
Dockerfile
+6
-1
Dockerfile
···
20
label org.opencontainers.image.vendor='tangled.sh'
21
label org.opencontainers.image.licenses='MIT'
22
23
copy rootfs .
24
run chmod 755 /etc
25
run chmod -R 755 /etc/s6-overlay
26
run apk add shadow s6-overlay execline openssl openssh git curl bash
27
-
run useradd -d /home/git git && openssl rand -hex 16 | passwd --stdin git
28
run mkdir -p /home/git/repositories && chown -R git:git /home/git
29
copy --from=builder /usr/bin/knot /usr/bin
30
run mkdir /app && chown -R git:git /app
···
20
label org.opencontainers.image.vendor='tangled.sh'
21
label org.opencontainers.image.licenses='MIT'
22
23
+
arg UID=1000
24
+
arg GID=1000
25
+
26
copy rootfs .
27
run chmod 755 /etc
28
run chmod -R 755 /etc/s6-overlay
29
run apk add shadow s6-overlay execline openssl openssh git curl bash
30
+
run groupadd -g $GID -f git
31
+
run useradd -u $UID -g $GID -d /home/git git
32
+
run openssl rand -hex 16 | passwd --stdin git
33
run mkdir -p /home/git/repositories && chown -R git:git /home/git
34
copy --from=builder /usr/bin/knot /usr/bin
35
run mkdir /app && chown -R git:git /app
+5
-1
docker-compose.yml
+5
-1
docker-compose.yml
+16
-2
readme.md
+16
-2
readme.md
···
29
The command above for example will build the latest commit on the `master`
30
branch.
31
32
<hr style="margin-bottom: 20px; margin-top: 10px" />
33
34
-
When using compose, it can be specified as a build argument which will be
35
passed to the builder.
36
37
```yaml
38
build:
39
context: .
40
-
args: { TAG: master }
41
```
42
43
This will for example tell docker to build it using the `master` branch like
···
29
The command above for example will build the latest commit on the `master`
30
branch.
31
32
+
By default it will also create a `git` user with user and group ID 1000:1000,
33
+
but you can change it with the `UID` and `GID` build arguments.
34
+
35
+
```sh
36
+
docker build -t knot:latest --build-arg UID=$(id -u) GID=$(id -g)
37
+
```
38
+
39
+
The command above for example will create a user with the host user's UID and GID.
40
+
This is useful if you are bind mounting the repositories and app folder on the host,
41
+
as in the provided `docker-compose.yml` file.
42
+
43
<hr style="margin-bottom: 20px; margin-top: 10px" />
44
45
+
When using compose, these can be specified as build arguments which will be
46
passed to the builder.
47
48
```yaml
49
build:
50
context: .
51
+
args:
52
+
TAG: master
53
+
UID: 1000
54
+
GID: 1000
55
```
56
57
This will for example tell docker to build it using the `master` branch like
History
1 round
3 comments
ionchy.ca
submitted
#0
1 commit
expand
collapse
Add
UID and GID arguments to Dockerfile
`UID` and `GID` args can now be set during build,
so following the example command in the README should fix
[#2](https://tangled.sh/@tangled.sh/knot-docker/issues/2)
by providing a `UID` and `GID` that exist on the host
so that the directories owned by git in the container
can be bind mounted on the host.
expand 3 comments
actually i think that's probably overkill, arg should be fine
@knotbin.com it wouldn't be overkill for those of us running the prebuilt image
pull request successfully merged
The UID and GID arguments should probably be env variables so they can be changed in managed environments like Coolify or Railway but if it's too hard to resubmit the PR with JJ, I can just merge and patch this after.