tangled.org / core

Monorepo for Tangled tangled.org

fork atom

appview/db: more flexible tables #996

open opened by

boltless.me 1 week ago targeting master from sl/sqkrqopzkvoo

migrate tables: stars, reactions, follows, public_keys

Two major changes:

Remove autoincrement id for these tables.

AUTOINCREMENT primary key does not help much for these tables and only introduces slice performance overhead. Use default rowid with non-autoincrement integer instead.

Remove unique constraints other than (did, rkey)

We cannot block users creating non-unique atproto records. Appview needs to handle those properly. For example, if user unstar a repo, appview should delete all existing star records pointing to that repo.

To allow this, remove all constraints other than (did, rkey).

Minor changes done while migrating tables:

rename thread_at in reactions to subject_at to match with other tables
follow common column names like did and created
allow self-follow (similar reason to 2nd major change. we should block it from service layer instead)

Signed-off-by: Seongmin Lee git@boltless.me

STACK 8

#1000 appview: remove db.GetReaction()

2/3

0 comments

round #1

#999 appview: handle non-unique publicKey records

2/3

0 comments

round #1

#998 appview: upsert star/reaction/follow records

1/3

0 comments

round #1

#997 appview/{db,state}: delete all duplicate records on delete

1/3

0 comments

round #1

#996 appview/db: more flexible tables

1/3

0 comments

round #1

#995 appview/db: remove foreign key constraint between collections

1/3

0 comments

round #1

#994 appview: move tx rollback logic out of db.UpsertProfile()

1/3

0 comments

round #1

#993 appview: remove validator

1/3

1 comment

round #1

Labels

None yet.

assignee

None yet.

Participants 1

AT URI

at://did:plc:xasnlahkri4ewmbuzly2rlc5/sh.tangled.repo.pull/3mcsfwwhtpn22

+8 -8

4 changed files

Interdiff #0 → #1

expand all

unified split

appview

db.go

follow.go

reaction.go

timeline.go

+8 -8

appview/db/db.go

··· 1197 return err 1198 }) 1199 1200 // several changes here 1201 // 1. remove autoincrement id for these tables 1202 // 2. remove unique constraints other than (did, rkey) to handle non-unique atproto records ··· 1307 }) 1308 1309 return &DB{ 1310 - db, 1311 - logger, 1312 - 1313 - 1314 - return err 1315 - }) 1316 - 1317 - return &DB{ 1318 db, 1319 logger,

··· 1197 return err 1198 }) 1199 1200 + return &DB{ 1201 + db, 1202 + logger, 1203 + 1204 + 1205 + return err 1206 + }) 1207 + 1208 // several changes here 1209 // 1. remove autoincrement id for these tables 1210 // 2. remove unique constraints other than (did, rkey) to handle non-unique atproto records ··· 1315 }) 1316 1317 return &DB{ 1318 db, 1319 logger,

appview/db/follow.go

This file has not been changed.

appview/db/reaction.go

This file has not been changed.

appview/db/timeline.go

This file has not been changed.