tangled.org / core
Monorepo for Tangled tangled.org
fork atom

nix,spindle: switch to tap from jetstream #982

open opened by boltless.me targeting master from sl/spindle-rewrite

spindle-tap will collect/stream record events from:

  • users dynamically added by spindle (spindle members | collaborators of repos using spindle)
  • any users with sh.tangled.repo.pull collection

It might be bit inefficient considering it will also stream repo creation events from PR authors due to second rule, but at least we now have backfill logic and Sync 1.1 based syncing.

This inefficiency can be fixed later by modifying upstream tap cli or embedding tap into spindle.

+--------- all tangled users --------+
|                                    |
| +-- users known to spindle-tap --+ |
| |  (PR author / manually added)  | |
| |                                | |
| | +----------------------------+ | |
| | |   users known to spindle   | | |
| | |  (members / collaborators) | | |
| | +----------------------------+ | |
| +--------------------------------+ |
+------------------------------------+

Close: https://tangled.org/tangled.org/core/issues/341

Signed-off-by: Seongmin Lee git@boltless.me

STACK 13
#987 appview: listen for pipeline events from spindlestream
2/3
0
#3
#986 knotserver,spindle: remove all pipeline logics from knotserver
1/3
0
#3
#985 spindle: create pipeline events from spindle
1/3
0
#3
#984 nix,spindle: sync workflow files on sh.tangled.git.refUpdate
1/3
0
#3
#983 nix,spindle: use DATA_DIR for db & other spindle data
1/3
0
#3
#982 nix,spindle: switch to tap from jetstream
1/3
0
#3
#981 spindle: recreate repos table
1/3
0
#3
#980 orm: ensure migrations table exist
1/3
0
#3
#979 nix: add tap service for spindle
2/3
0
#3
#978 tap: add tap client package
3/3
0
#3
#977 spindle: switch to rbac2
2/3
0
#3
#976 rbac2: rbac enforcer rewrite
1/3
0
#3
#975 nix: add more nix packages/modules related to atproto
1/3
0
#3
Labels

None yet.

assignee

None yet.

Participants 1
AT URI
at://did:plc:xasnlahkri4ewmbuzly2rlc5/sh.tangled.repo.pull/3mckguakeya22
+1 -1
Interdiff #0 → #1
unified split
nix/modules/spindle.nix

This file has not been changed.

nix/vm.nix

This file has not been changed.

spindle/config/config.go

This file has not been changed.

spindle/db/db.go

This file has not been changed.

spindle/db/known_dids.go

This file has not been changed.

spindle/db/repos.go

This file has not been changed.

spindle/ingester.go

This file has not been changed.

spindle/server.go

This file has not been changed.

+1 -1
spindle/tap.go
··· 84 84 return fmt.Errorf("adding member to rbac: %w", err) 85 85 } 86 86 if err := s.tap.AddRepos(ctx, []syntax.DID{syntax.DID(record.Subject)}); err != nil { 87 - return fmt.Errorf("adding did to tap", err) 87 + return fmt.Errorf("adding did to tap: %w", err) 88 88 } 89 89 90 90 l.Info("added member", "member", record.Subject)

History

4 rounds 0 comments
sign up or login to add to the discussion
boltless.me submitted #3
diff interdiff
1 commit
expand
13b2cec3
nix,spindle: switch to tap from jetstream
2/3 timeout, 1/3 success
expand
build.yml
fmt.yml
test.yml
no conflicts, ready to merge
expand 0 comments
boltless.me submitted #2
diff interdiff
1 commit
expand
a2920c04
nix,spindle: switch to tap from jetstream
1/3 failed, 2/3 success
expand
build.yml
fmt.yml
test.yml
expand 0 comments
boltless.me submitted #1
interdiff
1 commit
expand
cd62d65e
nix,spindle: switch to tap from jetstream
1/3 failed, 2/3 success
expand
build.yml
fmt.yml
test.yml
expand 0 comments
boltless.me submitted #0
diff
1 commit
expand
61367e8d
nix,spindle: switch to tap from jetstream
1/3 failed, 2/3 success
expand
build.yml
fmt.yml
test.yml
expand 0 comments