tangled.org / core
Monorepo for Tangled tangled.org
fork atom

state: add account switch/remove endpoints and login flow #944

open
opened by lewis.moe targeting master from lewis.moe/tangled-core: master
STACK 5
#944 state: add account switch/remove endpoints and login flow
1
#1
#943 appview: migrate handlers to GetMultiAccountUser
0
#1
#942 pages: support MultiAccountUser in templates and params
0
#1
#941 oauth: integrate multi-account into session management
0
#1
#940 oauth: add multi-account infrastructure
0
#1
0
by lewis.moe 2 comments
expand 1 commit
1e084577
state: add account switch/remove endpoints and login flow
boltless.me

Thank you for the contribution! The UI looks pretty good.

From high level, I found some bug when I run this locally.

  1. login with account A, add account B too (works well)
  2. then, logout from account A, back to login page and try switch to B
  3. silently fails and redirected to /login?return_url=%2Flogin.

Account switching after logout shouldn't fail and we should redirect back to /login instead and avoid recursion.

lewis.moe

Oh nice catch! Simple fix, though I'm not a jj wizard so it might take a bit for me to figure out how to properly have it show up here. :p

Fix is live on tangled.wizardry.systems at least

sign up or login to add to the discussion
1
by lewis.moe 1 comment
expand 1 commit
f5301156
state: add account switch/remove endpoints and login flow
lewis.moe

@boltless.me here was the fix line, the new round and my force push makes it hard to see: https://tangled.org/tangled.org/core/pulls/944/round/1#appview%2fstate%2frouter.go-N135

just making the switch endpoint unauthed

no conflicts, ready to merge
sign up or login to add to the discussion
Labels

None yet.

assignee

None yet.

Participants 2
AT URI
at://did:plc:3fwecdnvtcscjnrx2p4n7alz/sh.tangled.repo.pull/3mc2mfptash22