Monorepo for Tangled tangled.org

appview/pages: make user references clickable #939

merged opened by moshyfawn.dev targeting master from moshyfawn.dev/core: feat/clickable-user-refs

Wrap participant avatars with profile links. Make DID-type labels fully clickable chips linking to user profiles, matching the commit hash chip pattern

Signed-off-by: moshyfawn email@moshyfawn.dev

Labels

None yet.

assignee

None yet.

Participants 2
AT URI
at://did:plc:sshwio5obbx4zjfrn3fhsen6/sh.tangled.repo.pull/3mbxnxoqilb22
Interdiff #0 โ†’ #1
appview/pages/templates/fragments/tinyAvatarList.html

This file has not been changed.

appview/pages/templates/labels/fragments/label.html

This file has not been changed.

History

2 rounds 5 comments
sign up or login to add to the discussion
1 commit
expand
appview/pages: make user references clickable
expand 5 comments

Sorry for the resubmit: I was checking whether tangled supports GPG signing and if it could handle re-signing the commit with SSH, since that seems to be the only verification method currently supported. I confirmed 446d2d9e is signed locally - "Good 'git' signature" - but my fork doesn't show the verified badge in the commit history.

Again, apologies for the noise, just experimenting with the platform.

Ah, scrap that. I see the commit verification status now ๐Ÿซฃ

lgtm! nice addition. one regression: when viewing the pulls/issues page and there is a label with, say, an assignee, it is rendered as a link using the styling of a link, as opposed to inheriting the color of the parent container. perhaps adding text-inherit to $chipClasses could fix this? not a deal breaker however.

going to merge this as-is, don't want to keep this on hold for such a small thing ;)

Thanks!

Created a PR to fix that; didn't see someone's committed it already

pull request successfully merged
1 commit
expand
appview/pages: make user references clickable
expand 0 comments