back round 0 view raw

appview/knots,spindles: ignore invalid handles when removing members #927

merged

opened by

yemou.pink 1 week ago targeting master

This was preventing knot and spindle owners from removing members if the members's handle became invalid

Fixes: https://tangled.org/tangled.org/core/issues/192

options

unified split

Changed files

-10

appview

knots

knots.go

spindles

spindles.go

-5

appview/knots/knots.go

··· 666 666 k.Pages.Notice(w, noticeId, "Failed to remove member, identity resolution failed.") 667 667 return 668 668 } 669 - if memberId.Handle.IsInvalidHandle() { 670 - l.Error("failed to resolve member identity to handle") 671 - k.Pages.Notice(w, noticeId, "Failed to remove member, identity resolution failed.") 672 - return 673 - } 674 669 675 670 // remove from enforcer 676 671 err = k.Enforcer.RemoveKnotMember(domain, memberId.DID.String())

-5

appview/spindles/spindles.go

··· 523 523 s.Pages.Notice(w, noticeId, "Failed to add member, identity resolution failed.") 524 524 return 525 525 } 526 - if memberId.Handle.IsInvalidHandle() { 527 - l.Error("failed to resolve member identity to handle") 528 - s.Pages.Notice(w, noticeId, "Failed to add member, identity resolution failed.") 529 - return 530 - } 531 526 532 527 // write to pds 533 528 client, err := s.OAuth.AuthorizedClient(r)