back interdiff of round #1 and #0

appview: support safari icons (favicon, bookmark) #922

closed
opened by boltless.me targeting master from sl/kuvknkxxvpvu

Safari < 26.0 doesn't support svg favicon and even after 26.0, it defaults to #000 color, resulting to black favicon on white background. It is better to have actual ico image hosted on /favicon.ico

To prevent chrome and other browsers choosing ico image for favicon over svg, we are restricting the favicon.ico size to 48x48.

180x180 apple-touch-icon.png is also needed to support Safari bookmark icons. Commonly known as "Favorites". Because Safari bookmark icons is pretty large, we are using logo-dolly (dolly with eyes) here.

reference: https://dev.to/masakudamatsu/favicon-nightmare-how-to-maintain-sanity-3al7

Fix: https://tangled.org/tangled.org/core/issues/306

Signed-off-by: Seongmin Lee git@boltless.me

options
unified split
files
appview
middleware
middleware.go
pages
assets
apple-touch-icon.png
favicon.ico
favicon.svg
pages.go
templates
layouts
base.html
state
router.go
state.go
nix
pkgs
appview-static-files.nix
ERROR
appview/middleware/middleware.go

Failed to calculate interdiff for this file.

ERROR
appview/pages/assets/apple-touch-icon.png

Failed to calculate interdiff for this file.

ERROR
appview/pages/assets/favicon.ico

Failed to calculate interdiff for this file.

ERROR
appview/pages/assets/favicon.svg

Failed to calculate interdiff for this file.

ERROR
appview/pages/pages.go

Failed to calculate interdiff for this file.

ERROR
appview/pages/templates/layouts/base.html

Failed to calculate interdiff for this file.

ERROR
appview/state/router.go

Failed to calculate interdiff for this file.

ERROR
appview/state/state.go

Failed to calculate interdiff for this file.

NEW
nix/pkgs/appview-static-files.nix
··· 26 26 cp -f ${inter-fonts-src}/InterVariable*.ttf fonts/ 27 27 cp -f ${ibm-plex-mono-src}/fonts/complete/woff2/IBMPlexMono*.woff2 fonts/ 28 28 cp -f ${actor-typeahead-src}/actor-typeahead.js . 29 + cp -f ${src}/appview/pages/assets/* . 29 30 # tailwindcss -c $src/tailwind.config.js -i $src/input.css -o tw.css won't work 30 31 # for whatever reason (produces broken css), so we are doing this instead 31 32 cd ${src} && ${tailwindcss}/bin/tailwindcss -i input.css -o $out/tw.css