spindle/models: use full at-uri for `TANGLED_PIPELINE_ID` #886

open

opened by

boltless.me 3 weeks ago targeting master from sl/okmkyytolvko

rkey itself isn't unique across the network because multiple different knots can emit same rkey. We should use full at-uri here instead.

Signed-off-by: Seongmin Lee git@boltless.me

options

unified split

Changed files

+1 -1

spindle

models

pipeline_env.go

+1 -1

spindle/models/pipeline_env.go

··· 20 // Standard CI environment variable 21 env["CI"] = "true" 22 23 - env["TANGLED_PIPELINE_ID"] = pipelineId.Rkey 24 25 // Repo info 26 if tr.Repo != nil {

··· 20 // Standard CI environment variable 21 env["CI"] = "true" 22 23 + env["TANGLED_PIPELINE_ID"] = pipelineId.AtUri().String() 24 25 // Repo info 26 if tr.Repo != nil {