appview/gfi: render gfi label when there isn't any matching issues #702

merged
opened by boltless.me targeting master from sandboxed-atmosphere

although it might not happen, the appview should be able to handle when there is no single issue with good-first-issue label

Signed-off-by: Seongmin Lee git@boltless.me

Changed files
+9 -1
appview
state
+9 -1
appview/state/gfi.go
··· 22 23 goodFirstIssueLabel := fmt.Sprintf("at://%s/%s/%s", consts.TangledDid, tangled.LabelDefinitionNSID, "good-first-issue") 24 25 repoLabels, err := db.GetRepoLabels(s.db, db.FilterEq("label_at", goodFirstIssueLabel)) 26 if err != nil { 27 log.Println("failed to get repo labels", err) ··· 35 RepoGroups: []*models.RepoGroup{}, 36 LabelDefs: make(map[string]*models.LabelDefinition), 37 Page: page, 38 }) 39 return 40 } ··· 143 RepoGroups: paginatedGroups, 144 LabelDefs: labelDefsMap, 145 Page: page, 146 - GfiLabel: labelDefsMap[goodFirstIssueLabel], 147 }) 148 }
··· 22 23 goodFirstIssueLabel := fmt.Sprintf("at://%s/%s/%s", consts.TangledDid, tangled.LabelDefinitionNSID, "good-first-issue") 24 25 + gfiLabelDef, err := db.GetLabelDefinition(s.db, db.FilterEq("at_uri", goodFirstIssueLabel)) 26 + if err != nil { 27 + log.Println("failed to get gfi label def", err) 28 + s.pages.Error500(w) 29 + return 30 + } 31 + 32 repoLabels, err := db.GetRepoLabels(s.db, db.FilterEq("label_at", goodFirstIssueLabel)) 33 if err != nil { 34 log.Println("failed to get repo labels", err) ··· 42 RepoGroups: []*models.RepoGroup{}, 43 LabelDefs: make(map[string]*models.LabelDefinition), 44 Page: page, 45 + GfiLabel: gfiLabelDef, 46 }) 47 return 48 } ··· 151 RepoGroups: paginatedGroups, 152 LabelDefs: labelDefsMap, 153 Page: page, 154 + GfiLabel: gfiLabelDef, 155 }) 156 }