appview/gfi: render gfi label when there isn't any matching issues #702

merged
opened by boltless.me targeting master from sandboxed-atmosphere

although it might not happen, the appview should be able to handle when there is no single issue with good-first-issue label

Signed-off-by: Seongmin Lee git@boltless.me

Changed files
+9 -1
appview
state
+9 -1
appview/state/gfi.go
··· 25 26 goodFirstIssueLabel := fmt.Sprintf("at://%s/%s/%s", consts.TangledDid, tangled.LabelDefinitionNSID, "good-first-issue") 27 28 repoLabels, err := db.GetRepoLabels(s.db, db.FilterEq("label_at", goodFirstIssueLabel)) 29 if err != nil { 30 log.Println("failed to get repo labels", err) ··· 38 RepoGroups: []*models.RepoGroup{}, 39 LabelDefs: make(map[string]*models.LabelDefinition), 40 Page: page, 41 }) 42 return 43 } ··· 146 RepoGroups: paginatedGroups, 147 LabelDefs: labelDefsMap, 148 Page: page, 149 - GfiLabel: labelDefsMap[goodFirstIssueLabel], 150 }) 151 }
··· 25 26 goodFirstIssueLabel := fmt.Sprintf("at://%s/%s/%s", consts.TangledDid, tangled.LabelDefinitionNSID, "good-first-issue") 27 28 + gfiLabelDef, err := db.GetLabelDefinition(s.db, db.FilterEq("at_uri", goodFirstIssueLabel)) 29 + if err != nil { 30 + log.Println("failed to get gfi label def", err) 31 + s.pages.Error500(w) 32 + return 33 + } 34 + 35 repoLabels, err := db.GetRepoLabels(s.db, db.FilterEq("label_at", goodFirstIssueLabel)) 36 if err != nil { 37 log.Println("failed to get repo labels", err) ··· 45 RepoGroups: []*models.RepoGroup{}, 46 LabelDefs: make(map[string]*models.LabelDefinition), 47 Page: page, 48 + GfiLabel: gfiLabelDef, 49 }) 50 return 51 } ··· 154 RepoGroups: paginatedGroups, 155 LabelDefs: labelDefsMap, 156 Page: page, 157 + GfiLabel: gfiLabelDef, 158 }) 159 }